Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated packages updated. Only minor versions. #8291

Merged
merged 8 commits into from Jan 7, 2020
Merged

Outdated packages updated. Only minor versions. #8291

merged 8 commits into from Jan 7, 2020

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Jan 3, 2020 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Not really
New feature? Not really
Automated tests included? /
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? N
Deprecations? N

Description:

I used $ composer outdated -D command to find out which dependencies are outdated and can be updated without any harm.

Update of the CS Fixer probably added new rule to remove comments with duplicated information. So I run the CS Fixer and that's the big commit.

Steps to test this PR:

  1. Load up this PR
  2. Click around. There should not be any error.

@escopecz escopecz added code-review-needed PR's that require a code review before merging Mautic 3 ready-to-test PR's that are ready to test labels Jan 3, 2020
@escopecz escopecz added this to Needs code review and/or test in Mautic 3 Jan 3, 2020
@escopecz escopecz added this to the 3.0.0 milestone Jan 3, 2020
@escopecz escopecz moved this from Needs code review and/or test to In progress in Mautic 3 Jan 3, 2020
@escopecz escopecz self-assigned this Jan 3, 2020
@escopecz escopecz changed the title Outdated packages updated. Only minor versions so there should not be… Outdated packages updated. Only minor versions. Jan 3, 2020
@escopecz escopecz force-pushed the composer-minor-versions-update branch 2 times, most recently from e29e877 to 4ed9f02 Compare January 6, 2020 12:45
@dongilbert
Copy link
Member

Some conflicts with composer.json and lock

@escopecz escopecz force-pushed the composer-minor-versions-update branch from 951fc34 to ddcf765 Compare January 6, 2020 15:35
dongilbert
dongilbert approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@dongilbert dongilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits updating the outdated packages are good. The other commits with the CS fixes, there's just no way I can review 1,429 files.

@dongilbert dongilbert merged commit 53d16e1 into mautic:3.x Jan 7, 2020
@escopecz escopecz deleted the composer-minor-versions-update branch January 7, 2020 16:14
@escopecz
Copy link
Sponsor Member Author

escopecz commented Jan 7, 2020

Thanks Don!

@escopecz escopecz moved this from In progress to Done in Mautic 3 Jan 7, 2020
@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongilbert dongilbert dongilbert approved these changes

Assignees

@escopecz escopecz

Labels
None yet
Projects
No open projects
Mautic 3
  
Done
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@escopecz @dongilbert