Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated options from the email transport select box #8304

Merged
merged 1 commit into from Jan 6, 2020
Merged

Remove duplicated options from the email transport select box #8304

merged 1 commit into from Jan 6, 2020

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Jan 6, 2020

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? N
Deprecations? N

Description:

All options in the Mautic config > email settings > email transport select box are duplicated.

Steps to reproduce the bug:

  1. Go to Mautic config > email settings >
  2. Notice that the email transport select box has duplicated options. Instead of 12 options there are 24.

Steps to test this PR:

  1. Load up this PR
  2. There are only 12 options

@escopecz escopecz added bug Issues or PR's relating to bugs code-review-needed PR's that require a code review before merging essential This must be done to close the milestone Mautic 3 ready-to-test PR's that are ready to test labels Jan 6, 2020
@escopecz escopecz added this to the 3.0.0 milestone Jan 6, 2020
hluchas
hluchas approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@hluchas hluchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@escopecz escopecz merged commit b4fa59f into mautic:3.x Jan 6, 2020
@escopecz escopecz removed code-review-needed PR's that require a code review before merging essential This must be done to close the milestone ready-to-test PR's that are ready to test labels Jan 6, 2020
@escopecz escopecz deleted the m3.email-transport-select-fix branch January 6, 2020 14:11
@escopecz escopecz modified the milestones: 3.0.0-beta, 3.0.0 Mar 4, 2020
@escopecz escopecz added this to Done in Mautic 3 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hluchas hluchas hluchas approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs
Projects
No open projects
Mautic 3
  
Done
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@escopecz @hluchas