Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove doctrine/doctrine-cache-bundle #8319

Merged
merged 1 commit into from Jan 10, 2020
Merged

Remove doctrine/doctrine-cache-bundle #8319

merged 1 commit into from Jan 10, 2020

Conversation

anton-vlasenko
Copy link
Contributor

@anton-vlasenko anton-vlasenko commented Jan 9, 2020 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8289
BC breaks? doctrine/doctrine-cache-bundle is removed because we are supposed to use symfony/cache package
Deprecations?

Description:

doctrine/doctrine-cache-bundle should be removed from composer.json because we now use symfony/cache for caching.

Steps to test this PR:

  1. Load up this PR
  2. composer install
  3. Clear the cache. Make sure Mautic is loading.

@anton-vlasenko anton-vlasenko added Mautic 3 code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Jan 9, 2020
@anton-vlasenko anton-vlasenko added this to the 3.0.0 milestone Jan 9, 2020
@anton-vlasenko anton-vlasenko mentioned this pull request Jan 9, 2020
Closed
@anton-vlasenko anton-vlasenko added the essential This must be done to close the milestone label Jan 9, 2020
@alanhartless alanhartless merged commit 35a1778 into mautic:3.x Jan 10, 2020
@anton-vlasenko anton-vlasenko removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

@escopecz escopecz Awaiting requested review from escopecz

Assignees
No one assigned
Labels
essential This must be done to close the milestone
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anton-vlasenko @alanhartless