Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codeception to avoid abandoned package #8342

Merged
merged 2 commits into from Jan 21, 2020

Conversation

escopecz
Copy link
Sponsor Member

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? /
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? Theoretically yes, but I don't think anyone use the codeception library at the moment.
Deprecations? N

Description:

Composer reported:

`Package facebook/webdriver is abandoned, you should avoid using it. Use php-webdriver/webdriver instead.

The facebook/webdriver package was dependency of codeception/codeception. The solution I suggest is to upgrade codeception to v4 which doesn't use that dependency. Mautic is prepared for codeception tests but I don't thin any such test exists now so the update should not break anything.

Steps to reproduce the bug:

  1. Run composer install and notice the warning.

Steps to test this PR:

  1. Repeat the steps, and the warning should be gone.
  2. I'd consider passing Travis CI tests as a successful test in this case. It cannot break anything in Mautic itself as it is just a dev dependency.

Package facebook/webdriver is abandoned, you should avoid using it. Use php-webdriver/webdriver instead.
@escopecz escopecz added code-review-needed PR's that require a code review before merging Mautic 3 ready-to-test PR's that are ready to test labels Jan 21, 2020
@escopecz escopecz added this to the 3.0.0 milestone Jan 21, 2020
@escopecz escopecz added this to Needs code review and/or test in Mautic 3 Jan 21, 2020
Copy link
Contributor

@anton-vlasenko anton-vlasenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis CI doesn't show any errors, no traces of the facebook/webdriver in composer logs so I approve this PR.
Just a small note: composer remove facebook/webdriver command worked for me too.

@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Jan 21, 2020
@anton-vlasenko anton-vlasenko moved this from Needs code review and/or test to Done in Mautic 3 Jan 21, 2020
@escopecz escopecz merged commit a158fe8 into mautic:3.x Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Mautic 3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants