Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Twig Test folders from deletion #8348

Merged
merged 1 commit into from Jan 23, 2020
Merged

Exclude Twig Test folders from deletion #8348

merged 1 commit into from Jan 23, 2020

Conversation

dennisameling
Copy link
Member

@dennisameling dennisameling commented Jan 22, 2020 •
edited by npracht

Closes #8329

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? X
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8329
BC breaks?
Deprecations?

Description:

Steps to reproduce the bug:

  1. See M3: Unsubscribe link with email campaign is broken #8329

Steps to test this PR:

  1. Load up this PR
  2. Follow the steps in M3: Unsubscribe link with email campaign is broken #8329. Step 4 shouldn't throw an error anymore

List deprecations along with the new alternative:

  1. N/A

List backwards compatibility breaks:

  1. N/A

@npracht npracht added bug Issues or PR's relating to bugs essential This must be done to close the milestone Mautic 3 ready-to-test PR's that are ready to test regression A bug that broke something in the last release and removed bug Issues or PR's relating to bugs labels Jan 23, 2020
@npracht npracht modified the milestones: 2.16.0, 3.0.0 Jan 23, 2020
@npracht npracht added this to Needs code review and/or test in Mautic 3 Jan 23, 2020
@escopecz escopecz removed this from Needs code review and/or test in Mautic 3 Jan 23, 2020
hluchas
hluchas approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@hluchas hluchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested and working. TY!

@escopecz escopecz merged commit fce96de into mautic:3.x Jan 23, 2020
@escopecz escopecz removed essential This must be done to close the milestone ready-to-test PR's that are ready to test regression A bug that broke something in the last release labels Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hluchas hluchas hluchas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dennisameling @hluchas @escopecz @npracht