Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 7.3 compatibility #8364

Merged
merged 1 commit into from Jan 29, 2020
Merged

Fix PHP 7.3 compatibility #8364

merged 1 commit into from Jan 29, 2020

Conversation

dennisameling
Copy link
Member

After merging #6991, the staging branch PHP 7.3 Travis test fails with the following error:

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

This PR fixes that warning.

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? X
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Steps to test this PR:

  1. If Travis tests in this PR pass, we should be good to go.

@dennisameling
Fix PHP 7.3 compatibility
37e582f 
Fixes warning: "continue" targeting switch is equivalent to "break".
@dennisameling dennisameling added this to the 2.16.0 milestone Jan 28, 2020
npracht
npracht approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed i with @Enc3phale, seems good :D

@dennisameling dennisameling added this to Ready to Commit (passed testing) in Mautic 2 Jan 29, 2020
@dennisameling dennisameling merged commit 4d99883 into mautic:staging Jan 29, 2020
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Mautic 2
  
Merged
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dennisameling @npracht