Optional fixtures #8377

lukassykora · 2020-01-30T15:37:10Z

Please be sure you are submitting this against the staging branch.

Q	A
Bug fix?	Yes
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)	#8359
BC breaks?
Deprecations?

Description:

The services that are not sometimes available need an argument optional=true. The config.php was modified to remove the services where the argument is optional = true and class does not exist.

Steps to reproduce the bug:

After build process run php bin/console

Steps to test this PR:

After build process run php bin/console, there should not be any error

anton-vlasenko

Please resolve merge conflict.

escopecz · 2020-02-03T13:01:30Z

Rebased. Conflicts in compser.json resolved by running composer update

anton-vlasenko

There is a merge conflict again. It has to be resolved.
I've generated the package, installed it and got the following error in the console (php bin/console).

PHP Warning:  include(vendor/composer/../../plugins/MauticCitrixBundle/Tests/DataFixtures/ORM/LoadCitrixData.php): failed to open stream: No such file or directory in vendor/composer/ClassLoader.php on line 444
PHP Stack trace:
PHP   1. {main}() bin/console:0
PHP   2. Symfony\Bundle\FrameworkBundle\Console\Application->run() bin/console:41
PHP   3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() vendor/symfony/console/Application.php:148
PHP   4. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() vendor/symfony/framework-bundle/Console/Application.php:74
PHP   5. Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() vendor/symfony/console/Application.php:255
PHP   6. Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() vendor/symfony/framework-bundle/Console/Application.php:86
PHP   7. Symfony\Component\Console\Command\ListCommand->run() vendor/symfony/console/Application.php:1001
PHP   8. Symfony\Component\Console\Command\ListCommand->execute() vendor/symfony/console/Command/Command.php:255
PHP   9. Symfony\Component\Console\Helper\DescriptorHelper->describe() vendor/symfony/console/Command/ListCommand.php:75
PHP  10. Symfony\Component\Console\Descriptor\TextDescriptor->describe() vendor/symfony/console/Helper/DescriptorHelper.php:67
PHP  11. Symfony\Component\Console\Descriptor\TextDescriptor->describeApplication() vendor/symfony/console/Descriptor/Descriptor.php:55
PHP  12. Symfony\Component\Console\Descriptor\ApplicationDescription->getCommands() vendor/symfony/console/Descriptor/TextDescriptor.php:194
PHP  13. Symfony\Component\Console\Descriptor\ApplicationDescription->inspectApplication() vendor/symfony/console/Descriptor/ApplicationDescription.php:75
PHP  14. Symfony\Bundle\FrameworkBundle\Console\Application->all() vendor/symfony/console/Descriptor/ApplicationDescription.php:102
PHP  15. Symfony\Bundle\FrameworkBundle\Console\Application->all() vendor/symfony/framework-bundle/Console/Application.php:122
PHP  16. Symfony\Bundle\FrameworkBundle\Console\Application->has() vendor/symfony/console/Application.php:706
PHP  17. Symfony\Component\Console\CommandLoader\ContainerCommandLoader->get() vendor/symfony/console/Application.php:518
PHP  18. Symfony\Component\DependencyInjection\ServiceLocator->get() vendor/symfony/console/CommandLoader/ContainerCommandLoader.php:46
PHP  19. ContainerDxavvtd\appProdProjectContainer->{closure:var/cache/prod/ContainerDxavvtd/getConsole_CommandLoaderService.php:64-66}() vendor/symfony/dependency-injection/ServiceLocator.php:64
PHP  20. ContainerDxavvtd\appProdProjectContainer->load() var/cache/prod/ContainerDxavvtd/getConsole_CommandLoaderService.php:65
PHP  21. require() var/cache/prod/ContainerDxavvtd/appProdProjectContainer.php:5489
PHP  22. ContainerDxavvtd\appProdProjectContainer->load() var/cache/prod/ContainerDxavvtd/getDoctrine_FixturesLoadCommandService.php:9
PHP  23. require() var/cache/prod/ContainerDxavvtd/appProdProjectContainer.php:5489
PHP  24. spl_autoload_call() var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php:8
PHP  25. Composer\Autoload\ClassLoader->loadClass() var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php:8
PHP  26. Composer\Autoload\includeFile() vendor/composer/ClassLoader.php:322

Warning: include(vendor/composer/../../plugins/MauticCitrixBundle/Tests/DataFixtures/ORM/LoadCitrixData.php): failed to open stream: No such file or directory in vendor/composer/ClassLoader.php on line 444

Call Stack:
    0.0017     400720   1. {main}() bin/console:0
    0.0512    7245064   2. Symfony\Bundle\FrameworkBundle\Console\Application->run() bin/console:41
    0.0646    7631176   3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() vendor/symfony/console/Application.php:148
    0.3054   37891688   4. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() vendor/symfony/framework-bundle/Console/Application.php:74
    0.3058   37891608   5. Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() vendor/symfony/console/Application.php:255
    0.3058   37891608   6. Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() vendor/symfony/framework-bundle/Console/Application.php:86
    0.3067   37905272   7. Symfony\Component\Console\Command\ListCommand->run() vendor/symfony/console/Application.php:1001
    0.3070   37906288   8. Symfony\Component\Console\Command\ListCommand->execute() vendor/symfony/console/Command/Command.php:255
    0.3101   38126400   9. Symfony\Component\Console\Helper\DescriptorHelper->describe() vendor/symfony/console/Command/ListCommand.php:75
    0.3101   38126400  10. Symfony\Component\Console\Descriptor\TextDescriptor->describe() vendor/symfony/console/Helper/DescriptorHelper.php:67
    0.3101   38126400  11. Symfony\Component\Console\Descriptor\TextDescriptor->describeApplication() vendor/symfony/console/Descriptor/Descriptor.php:55
    0.3139   38141728  12. Symfony\Component\Console\Descriptor\ApplicationDescription->getCommands() vendor/symfony/console/Descriptor/TextDescriptor.php:194
    0.3139   38141728  13. Symfony\Component\Console\Descriptor\ApplicationDescription->inspectApplication() vendor/symfony/console/Descriptor/ApplicationDescription.php:75
    0.3139   38141728  14. Symfony\Bundle\FrameworkBundle\Console\Application->all() vendor/symfony/console/Descriptor/ApplicationDescription.php:102
    0.3139   38141728  15. Symfony\Bundle\FrameworkBundle\Console\Application->all() vendor/symfony/framework-bundle/Console/Application.php:122
    0.3640   42766264  16. Symfony\Bundle\FrameworkBundle\Console\Application->has() vendor/symfony/console/Application.php:706
    0.3640   42766264  17. Symfony\Component\Console\CommandLoader\ContainerCommandLoader->get() vendor/symfony/console/Application.php:518
    0.3641   42766264  18. Symfony\Component\DependencyInjection\ServiceLocator->get() vendor/symfony/console/CommandLoader/ContainerCommandLoader.php:46
    0.3641   42766264  19. ContainerDxavvtd\appProdProjectContainer->{closure:var/cache/prod/ContainerDxavvtd/getConsole_CommandLoaderService.php:64-66}() vendor/symfony/dependency-injection/ServiceLocator.php:64
    0.3641   42766584  20. ContainerDxavvtd\appProdProjectContainer->load() var/cache/prod/ContainerDxavvtd/getConsole_CommandLoaderService.php:65
    0.3642   42792840  21. require('var/cache/prod/ContainerDxavvtd/getDoctrine_FixturesLoadCommandService.php') var/cache/prod/ContainerDxavvtd/appProdProjectContainer.php:5489
    0.3906   45968728  22. ContainerDxavvtd\appProdProjectContainer->load() var/cache/prod/ContainerDxavvtd/getDoctrine_FixturesLoadCommandService.php:9
    0.3907   45970664  23. require('var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php') var/cache/prod/ContainerDxavvtd/appProdProjectContainer.php:5489
    0.3907   45970664  24. spl_autoload_call() var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php:8
    0.3907   45970760  25. Composer\Autoload\ClassLoader->loadClass() var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php:8
    0.3907   45970760  26. Composer\Autoload\includeFile() vendor/composer/ClassLoader.php:322

PHP Warning:  include(): Failed opening 'vendor/composer/../../plugins/MauticCitrixBundle/Tests/DataFixtures/ORM/LoadCitrixData.php' for inclusion (include_path='.:/usr/local/Cellar/php@7.2/7.2.25/share/php@7.2/pear') in vendor/composer/ClassLoader.php on line 444
PHP Stack trace:
PHP   1. {main}() bin/console:0
PHP   2. Symfony\Bundle\FrameworkBundle\Console\Application->run() bin/console:41
PHP   3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() vendor/symfony/console/Application.php:148
PHP   4. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() vendor/symfony/framework-bundle/Console/Application.php:74
PHP   5. Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() vendor/symfony/console/Application.php:255
PHP   6. Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() vendor/symfony/framework-bundle/Console/Application.php:86
PHP   7. Symfony\Component\Console\Command\ListCommand->run() vendor/symfony/console/Application.php:1001
PHP   8. Symfony\Component\Console\Command\ListCommand->execute() vendor/symfony/console/Command/Command.php:255
PHP   9. Symfony\Component\Console\Helper\DescriptorHelper->describe() vendor/symfony/console/Command/ListCommand.php:75
PHP  10. Symfony\Component\Console\Descriptor\TextDescriptor->describe() vendor/symfony/console/Helper/DescriptorHelper.php:67
PHP  11. Symfony\Component\Console\Descriptor\TextDescriptor->describeApplication() vendor/symfony/console/Descriptor/Descriptor.php:55
PHP  12. Symfony\Component\Console\Descriptor\ApplicationDescription->getCommands() vendor/symfony/console/Descriptor/TextDescriptor.php:194
PHP  13. Symfony\Component\Console\Descriptor\ApplicationDescription->inspectApplication() vendor/symfony/console/Descriptor/ApplicationDescription.php:75
PHP  14. Symfony\Bundle\FrameworkBundle\Console\Application->all() vendor/symfony/console/Descriptor/ApplicationDescription.php:102
PHP  15. Symfony\Bundle\FrameworkBundle\Console\Application->all() vendor/symfony/framework-bundle/Console/Application.php:122
PHP  16. Symfony\Bundle\FrameworkBundle\Console\Application->has() vendor/symfony/console/Application.php:706
PHP  17. Symfony\Component\Console\CommandLoader\ContainerCommandLoader->get() vendor/symfony/console/Application.php:518
PHP  18. Symfony\Component\DependencyInjection\ServiceLocator->get() vendor/symfony/console/CommandLoader/ContainerCommandLoader.php:46
PHP  19. ContainerDxavvtd\appProdProjectContainer->{closure:var/cache/prod/ContainerDxavvtd/getConsole_CommandLoaderService.php:64-66}() vendor/symfony/dependency-injection/ServiceLocator.php:64
PHP  20. ContainerDxavvtd\appProdProjectContainer->load() var/cache/prod/ContainerDxavvtd/getConsole_CommandLoaderService.php:65
PHP  21. require() var/cache/prod/ContainerDxavvtd/appProdProjectContainer.php:5489
PHP  22. ContainerDxavvtd\appProdProjectContainer->load() var/cache/prod/ContainerDxavvtd/getDoctrine_FixturesLoadCommandService.php:9
PHP  23. require() var/cache/prod/ContainerDxavvtd/appProdProjectContainer.php:5489
PHP  24. spl_autoload_call() var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php:8
PHP  25. Composer\Autoload\ClassLoader->loadClass() var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php:8
PHP  26. Composer\Autoload\includeFile() vendor/composer/ClassLoader.php:322

Warning: include(): Failed opening 'vendor/composer/../../plugins/MauticCitrixBundle/Tests/DataFixtures/ORM/LoadCitrixData.php' for inclusion (include_path='.:/usr/local/Cellar/php@7.2/7.2.25/share/php@7.2/pear') in vendor/composer/ClassLoader.php on line 444

Call Stack:
    0.0017     400720   1. {main}() bin/console:0
    0.0512    7245064   2. Symfony\Bundle\FrameworkBundle\Console\Application->run() bin/console:41
    0.0646    7631176   3. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() vendor/symfony/console/Application.php:148
    0.3054   37891688   4. Symfony\Bundle\FrameworkBundle\Console\Application->doRun() vendor/symfony/framework-bundle/Console/Application.php:74
    0.3058   37891608   5. Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() vendor/symfony/console/Application.php:255
    0.3058   37891608   6. Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() vendor/symfony/framework-bundle/Console/Application.php:86
    0.3067   37905272   7. Symfony\Component\Console\Command\ListCommand->run() vendor/symfony/console/Application.php:1001
    0.3070   37906288   8. Symfony\Component\Console\Command\ListCommand->execute() vendor/symfony/console/Command/Command.php:255
    0.3101   38126400   9. Symfony\Component\Console\Helper\DescriptorHelper->describe() vendor/symfony/console/Command/ListCommand.php:75
    0.3101   38126400  10. Symfony\Component\Console\Descriptor\TextDescriptor->describe() vendor/symfony/console/Helper/DescriptorHelper.php:67
    0.3101   38126400  11. Symfony\Component\Console\Descriptor\TextDescriptor->describeApplication() vendor/symfony/console/Descriptor/Descriptor.php:55
    0.3139   38141728  12. Symfony\Component\Console\Descriptor\ApplicationDescription->getCommands() vendor/symfony/console/Descriptor/TextDescriptor.php:194
    0.3139   38141728  13. Symfony\Component\Console\Descriptor\ApplicationDescription->inspectApplication() vendor/symfony/console/Descriptor/ApplicationDescription.php:75
    0.3139   38141728  14. Symfony\Bundle\FrameworkBundle\Console\Application->all() vendor/symfony/console/Descriptor/ApplicationDescription.php:102
    0.3139   38141728  15. Symfony\Bundle\FrameworkBundle\Console\Application->all() vendor/symfony/framework-bundle/Console/Application.php:122
    0.3640   42766264  16. Symfony\Bundle\FrameworkBundle\Console\Application->has() vendor/symfony/console/Application.php:706
    0.3640   42766264  17. Symfony\Component\Console\CommandLoader\ContainerCommandLoader->get() vendor/symfony/console/Application.php:518
    0.3641   42766264  18. Symfony\Component\DependencyInjection\ServiceLocator->get() vendor/symfony/console/CommandLoader/ContainerCommandLoader.php:46
    0.3641   42766264  19. ContainerDxavvtd\appProdProjectContainer->{closure:var/cache/prod/ContainerDxavvtd/getConsole_CommandLoaderService.php:64-66}() vendor/symfony/dependency-injection/ServiceLocator.php:64
    0.3641   42766584  20. ContainerDxavvtd\appProdProjectContainer->load() var/cache/prod/ContainerDxavvtd/getConsole_CommandLoaderService.php:65
    0.3642   42792840  21. require('var/cache/prod/ContainerDxavvtd/getDoctrine_FixturesLoadCommandService.php') var/cache/prod/ContainerDxavvtd/appProdProjectContainer.php:5489
    0.3906   45968728  22. ContainerDxavvtd\appProdProjectContainer->load() var/cache/prod/ContainerDxavvtd/getDoctrine_FixturesLoadCommandService.php:9
    0.3907   45970664  23. require('var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php') var/cache/prod/ContainerDxavvtd/appProdProjectContainer.php:5489
    0.3907   45970664  24. spl_autoload_call() var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php:8
    0.3907   45970760  25. Composer\Autoload\ClassLoader->loadClass() var/cache/prod/ContainerDxavvtd/getMautic_Citrix_Fixture_LoadCitrixDataService.php:8
    0.3907   45970760  26. Composer\Autoload\includeFile() vendor/composer/ClassLoader.php:322


In getMautic_Citrix_Fixture_LoadCitrixDataService.php line 8:
                                                                                                                     
  Attempted to load class "LoadCitrixData" from namespace "MauticPlugin\MauticCitrixBundle\Tests\DataFixtures\ORM".  
  Did you forget a "use" statement for another namespace?

anton-vlasenko

Nitpick: I've also noticed that the package generation takes considerably more time now (like 50%-100% more). I haven't performed any tests though, so this is just my rough estimate.
It could be related to that collection class we borrowed from Laravel. It may be too slow in comparison with php arrays.

dongilbert · 2020-02-03T14:03:48Z

The cache compilation happens once though so it's not an issue. It's better than creating an untested pass-by-reference array function to mimick the same functionality.

anton-vlasenko · 2020-02-03T14:12:18Z

The cache compilation happens once though so it's not an issue. It's better than creating an untested pass-by-reference array function to mimick the same functionality.

Good to know. Thanks for explaining, @dongilbert.
But I'm not sure if this issue is cache related. It always starts to build distribution package from scratch in a separate folder. So it must always take about the same time to build a package.
But I don't insist that we have to fix it.

dongilbert · 2020-02-03T14:16:53Z

I see - I didn't realize that's what you were talking about

lukassykora · 2020-02-03T15:33:47Z

There are changes in composer.json so maybe the longer time for generation relates to it.

escopecz · 2020-02-03T16:21:51Z

@lukassykora there are conflicts in composer.lock. I fixed it once today by rebasing, then running composer update, git rebase --continue and git push --force. If you won't get to it then I'll do it tomorrow morning.

dongilbert · 2020-02-03T21:10:30Z

The conflicts have been resolved following @escopecz's suggestion.

anton-vlasenko

@escopecz Could you please merge?

lukassykora mentioned this pull request Jan 30, 2020

"php bin/console" command (with no arguments) throws an exception #8359

Closed

anton-vlasenko self-requested a review January 30, 2020 15:42

alanhartless added this to the 3.0.0 milestone Feb 1, 2020

alanhartless added the Mautic 3 label Feb 1, 2020

anton-vlasenko suggested changes Feb 3, 2020

View reviewed changes

escopecz force-pushed the optional-fixtures branch from d3c96e5 to 19a569d Compare February 3, 2020 13:00

anton-vlasenko suggested changes Feb 3, 2020

View reviewed changes

anton-vlasenko reviewed Feb 3, 2020

View reviewed changes

lukassykora force-pushed the optional-fixtures branch from 19a569d to 2843ba8 Compare February 3, 2020 15:27

lukassykora requested a review from anton-vlasenko February 3, 2020 15:32

Lukas Sykora and others added 8 commits February 3, 2020 16:03

MAUT-3269 / Optional fixtures

1175804

MAUT-3269 / Fix load twice

3e01d73

MAUT-3269 / CS Fixer

85d32d4

MAUT-3269 / Don's solution

5d04304

tightenco/collect dependency composer.json

4150bbd

tightenco/collect dependency composer.lock

37cb6d9

MAUT-3269 / Optional fixture

86fbf25

Try to fix merge conflict

ccc3aba

dongilbert force-pushed the optional-fixtures branch from 80a8cb8 to ccc3aba Compare February 3, 2020 21:07

Update commit hash

955c9dc

anton-vlasenko approved these changes Feb 4, 2020

View reviewed changes

escopecz merged commit c141206 into mautic:3.x Feb 4, 2020

escopecz removed this from the 3.0.0-beta milestone Apr 6, 2020

escopecz added this to the 3.0.0 milestone Apr 6, 2020

escopecz added this to Needs code review and/or test in Mautic 3 Apr 6, 2020

escopecz added code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test and removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Apr 6, 2020

escopecz moved this from Needs code review and/or test to Done in Mautic 3 Apr 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optional fixtures #8377

Optional fixtures #8377

lukassykora commented Jan 30, 2020

anton-vlasenko left a comment

escopecz commented Feb 3, 2020

anton-vlasenko left a comment •

edited

anton-vlasenko left a comment •

edited

dongilbert commented Feb 3, 2020

anton-vlasenko commented Feb 3, 2020 •

edited

dongilbert commented Feb 3, 2020

lukassykora commented Feb 3, 2020

escopecz commented Feb 3, 2020

dongilbert commented Feb 3, 2020

anton-vlasenko left a comment

Optional fixtures #8377

Optional fixtures #8377

Conversation

lukassykora commented Jan 30, 2020

Description:

Steps to reproduce the bug:

Steps to test this PR:

anton-vlasenko left a comment

Choose a reason for hiding this comment

escopecz commented Feb 3, 2020

anton-vlasenko left a comment • edited

Choose a reason for hiding this comment

anton-vlasenko left a comment • edited

Choose a reason for hiding this comment

dongilbert commented Feb 3, 2020

anton-vlasenko commented Feb 3, 2020 • edited

dongilbert commented Feb 3, 2020

lukassykora commented Feb 3, 2020

escopecz commented Feb 3, 2020

dongilbert commented Feb 3, 2020

anton-vlasenko left a comment

Choose a reason for hiding this comment

anton-vlasenko left a comment •

edited

anton-vlasenko left a comment •

edited

anton-vlasenko commented Feb 3, 2020 •

edited