2.16.0 code fixes #8401
Merged
2.16.0 code fixes #8401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escopecz
added
code-review-needed
| @@ -153,7 +153,7 @@ | |||
| 'mautic_contact_index', | |||
| [ | |||
| 'search' => $view['translator']->trans('mautic.lead.lead.searchcommand.company').':"' | |||
| .$fields['core']['companyname']['value'].'"', | |||
| .$view->escape($fields['core']['companyname']['value']).'"', | |||
There was a problem hiding this comment.
Are you sure this doesn't conflict with #7760? That PR is doing the exact opposite 😅
There was a problem hiding this comment.
I should have been more thorough investigating origins of the change of this line. I and Don expected it was a bad merge conflict resolution. Will fix.
dennisameling
approved these changes
Feb 6, 2020
dongilbert
reviewed
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
This came from code review of #8380. I cherry-picked the changes so they can be applied back to 2.16.0 before the stable release. One of the changes increases security.
Steps to test this PR: