Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inability to display plugins config forms #8409

Merged
merged 4 commits into from Feb 7, 2020
Merged

Fix inability to display plugins config forms #8409

merged 4 commits into from Feb 7, 2020

Conversation

anton-vlasenko
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

It's impossible to display config forms for the following integrations: Twillio, FullContact, LinkedIn (SmsBundle).

Steps to reproduce the bug:

  1. Go to the plugins page.
  2. Try to click on Twilio, FullContact or LinkedIn plugins.
  3. You will get errors.

Steps to test this PR:

  1. Go to the plugins page.
  2. Try to load Twilio, FullContact or LinkedIn plugins.
  3. You will be able to view forms.

@anton-vlasenko anton-vlasenko self-assigned this Feb 6, 2020
@anton-vlasenko anton-vlasenko added this to the 3.0.0 milestone Feb 6, 2020
@anton-vlasenko anton-vlasenko added the bug Issues or PR's relating to bugs label Feb 6, 2020
@anton-vlasenko anton-vlasenko removed their assignment Feb 6, 2020
@anton-vlasenko anton-vlasenko added Mautic 3 code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Feb 6, 2020
@alanhartless alanhartless added this to Needs code review and/or test in Mautic 3 Feb 6, 2020
escopecz
escopecz approved these changes Feb 7, 2020
View reviewed changes
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@escopecz escopecz merged commit 13fc6ac into mautic:3.x Feb 7, 2020
@escopecz escopecz removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Feb 7, 2020
@escopecz escopecz moved this from Needs code review and/or test to Done in Mautic 3 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees

@anton-vlasenko anton-vlasenko

Labels
bug Issues or PR's relating to bugs
Projects
No open projects
Mautic 3
  
Done
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anton-vlasenko @escopecz