Adding Rector early-return set with generated changes #8414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escopecz
added
code-review-needed
escopecz
commented
Feb 10, 2020
| @@ -137,9 +140,7 @@ public static function parseList($list, $removeEmpty = true, $ignoreNumerical = | |||
| $val = $label['value']; | |||
| $label = $label['label']; | |||
| } | |||
| if ($removeEmpty && empty($val) && empty($label)) { | |||
There was a problem hiding this comment.
This should have not been moved up.
RCheesley
added
the
has-conflicts
|
@escopecz looks like a bunch of conflicts to be resolved |
|
I'll close this one as it is auto-generated by Rector anyway. We can get back to it once we merge the majority of existing PRs. It would cause a lot of manual work to resolve conflicts that this PR would create. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
Steps to reproduce the bug:
Steps to test this PR:
List deprecations along with the new alternative:
List backwards compatibility breaks: