Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration bundle flip array #8418

Merged
merged 3 commits into from Feb 10, 2020

Conversation

lukassykora
Copy link
Contributor

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Yes
New feature?
Automated tests included? No
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description: Thhe plugin can not work with Integration bundle. Problem is the flipped key, value pairs.

Steps to reproduce the bug:

  1. In the installation windows of plugin, there are visible keys coming from the Integration bundle like 'bidirectionally' in mapping section.
  2. There is also an error that integration.js is missing.

Steps to test this PR:

  1. Install plugin.
  2. Run sync: bin/console mautic:integrations:sync [PluginName]

List deprecations along with the new alternative:

List backwards compatibility breaks:

@alanhartless alanhartless added this to Needs code review and/or test in Mautic 3 Feb 10, 2020
@alanhartless alanhartless added this to the 3.0.0 milestone Feb 10, 2020
@alanhartless alanhartless merged commit 14e3a5b into mautic:3.x Feb 10, 2020
@alanhartless alanhartless moved this from Needs code review and/or test to Done in Mautic 3 Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Mautic 3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants