Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix var directory paths in installer #8421

Merged
merged 1 commit into from Feb 11, 2020
Merged

Fix var directory paths in installer #8421

merged 1 commit into from Feb 11, 2020

Conversation

hluchas
Copy link
Contributor

@hluchas hluchas commented Feb 10, 2020 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

  1. Installer is producing writable path errors in first step

Steps to reproduce the bug:

  1. Use mautic/3.x branch lcoally
  2. Delete local.php
  3. Send request to mautic and config check will display errors with paths

Steps to test this PR:

  1. Try this PR locally and it works

@hluchas
Copy link
Contributor Author

hluchas commented Feb 10, 2020

@alanhartless Still fixing

@hluchas hluchas added this to the 3.0.0 milestone Feb 10, 2020
@hluchas
Copy link
Contributor Author

hluchas commented Feb 10, 2020

@alanhartless Ready for merge

@hluchas hluchas changed the title WIP: Fix var directory paths Fix var directory paths in installer Feb 10, 2020
@alanhartless alanhartless merged commit ee7c320 into mautic:3.x Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hluchas @alanhartless