New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified integration interface #8433
Merged
escopecz
merged 17 commits into
mautic:3.x
from
alanhartless:unified-integration-interface
Feb 13, 2020
Merged
Unified integration interface #8433
escopecz
merged 17 commits into
mautic:3.x
from
alanhartless:unified-integration-interface
Feb 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty is more than enough in this particular case. 2. Remove weird exception codes.
We have to use mb_string library.
…erface class for test.
…to support icons for plugins based on IntegrationsBundle
…ings "supportedFeatures"
escopecz
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, don't see any problems clicking through the Citrix plugin config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the changes throughout Mautic to support the UnifiedIntegrationInterface required to support plugins that leverage the IntegrationsBundle.