Fixing PHP Warning - count(): Parameter must be an array or an object… #8448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that implements Countable in IteratorExportDataModel.php:71
hluchas
suggested changes
Feb 17, 2020
| $this->total = $this->total + count($this->data); | ||
| $this->totalResult = count($this->data); | ||
| $this->totalResult = $this->data ? count($this->data) : 0; | ||
| $this->total = $this->total + $this->totalResult; | ||
| $this->position = 0; | ||
| ++$this->page; |
There was a problem hiding this comment.
Could you please remove this line. Variable is not used and it's producing
PHP Notice - Undefined property: Mautic\CoreBundle\Model\IteratorExportDataModel::$page" at /Users/lukas.drahy/dev/community-fork/app/bundles/CoreBundle/Model/IteratorExportDataModel.php line 66
for me now.
hluchas
approved these changes
Feb 17, 2020
|
can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the staging branch.
Description:
PHP 7.2+ has problem with
count(null)ant throws this:This PR ensures that count will be called only with countable.
Steps to reproduce the bug:
Steps to test this PR: