Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix modal closing click release #8554

Closed
wants to merge 3 commits into from
Closed

fix modal closing click release #8554

wants to merge 3 commits into from

Conversation

Noa83
Copy link
Contributor

@Noa83 Noa83 commented Mar 11, 2020

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Yes
New feature? No
Automated tests included? No
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #8123
BC breaks? No
Deprecations? No

Description:

Fix a modal closing issue on click event.

Steps to reproduce the bug:

  1. Open a modal anywhere in mautic (form field adding for example)
  2. Click inside the modal and stay mousedown. Move your pointer outside the modal and release.
    The modal closes. (More details and gif: Modal component closing on click release event #8123)

Steps to test this PR:

  1. Load up this PR
  2. Regenerate assets and clear browser cache.
  3. Repeat the steps above. The modal doesn't close at the release (but keeps its normal behaviour when you click outside )

@npracht npracht added ready-to-test PR's that are ready to test user-interface Anything related to appearance, layout, and interactivity labels Mar 11, 2020
@npracht npracht linked an issue Mar 11, 2020 that may be closed by this pull request
Modal component closing on click release event #8123
Closed
@npracht npracht added this to the 2.16.1 milestone Mar 11, 2020
@dennisameling dennisameling removed this from the 2.16.1 milestone Mar 19, 2020
@kuzmany kuzmany mentioned this pull request Apr 16, 2020
Open
@enguerr enguerr mentioned this pull request May 20, 2020
Closed
@npracht npracht changed the base branch from staging to 3.x May 20, 2020 10:02
@npracht npracht added this to the 3.1.0 milestone May 20, 2020
@RCheesley RCheesley changed the base branch from 3.x to staging June 17, 2020 11:44
@kuzmany kuzmany changed the base branch from staging to 3.0 July 7, 2020 19:29
@kuzmany kuzmany changed the base branch from 3.0 to staging July 7, 2020 19:29
@kuzmany kuzmany force-pushed the fix_modal_closing_click_release branch 2 times, most recently from 935f741 to 1eb74b5 Compare July 7, 2020 19:40
@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited

Codecov Report

Merging #8554 into staging will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging    #8554   +/-   ##
==========================================
  Coverage      35.24%   35.24%           
  Complexity     27900    27900           
==========================================
  Files           1731     1731           
  Lines          96443    96443           
==========================================
  Hits           33987    33987           
  Misses         62456    62456

@RCheesley RCheesley added the needs-automated-tests PR's that need automated tests before they can be merged label Jul 7, 2020
@RCheesley
Copy link
Sponsor Member

@kuzmany could you take a look at the conflict please?

@RCheesley RCheesley added the has-conflicts Pull requests that cannot be merged until conflicts have been resolved label Jul 7, 2020
@kuzmany
Merge remote-tracking branch 'webmecanik/mautic/fix_modal_closing_cli…
9105a61 
…ck_release' into fix_modal_closing_click_release

# Conflicts:
#	app/bundles/CoreBundle/Assets/js/libraries/3.bootstrap.js
@kuzmany
Copy link
Member

kuzmany commented Jul 8, 2020

@Noa83 Please can you re-test on M3 https://mautibox.com/staging If still this issue persist?
I don't understand how to test it.

@kuzmany
Copy link
Member

kuzmany commented Jul 10, 2020

Not reproduce it on M3. Close it

@kuzmany kuzmany closed this Jul 10, 2020
@kuzmany kuzmany removed this from the 3.1.0 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-conflicts Pull requests that cannot be merged until conflicts have been resolved needs-automated-tests PR's that need automated tests before they can be merged ready-to-test PR's that are ready to test user-interface Anything related to appearance, layout, and interactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal component closing on click release event
5 participants
@Noa83 @RCheesley @kuzmany @npracht @dennisameling