Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tenerife and Toledo to Spain regions #8608

Merged
merged 2 commits into from Apr 7, 2020

Conversation

Anonyma
Copy link
Contributor

@Anonyma Anonyma commented Mar 28, 2020

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? X
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description: Added Tenerife and Toledo to Spain regions

Steps to reproduce the bug:

Steps to test this PR:

  1. Load up this PR

List deprecations along with the new alternative:

List backwards compatibility breaks:

npracht
npracht previously approved these changes Mar 29, 2020
@npracht npracht added enhancement Any improvement to an existing feature or functionality pending-test-confirmation PR's that require one test before they can be merged labels Mar 29, 2020
@npracht npracht added this to the 3.0.1 milestone Mar 29, 2020
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Anonyma thanks so much for this PR!

Usually for PR's like this it is helpful to have a link to where the official regions can be found, as this helps maintainers to check against the official listings.

I guess this is the most appropriate/definitive list: https://en.wikipedia.org/wiki/Provinces_of_Spain

I noticed that we already have Santa Cruz de Tenerife on the list, so we don't want to add a duplication issue with this one. Let's remove the Tenerife entry for that reason.

Toledo is indeed missing so it should be added to this list!

If you can update your branch to remove the Tenerife entry we can then look to get this merged :)

@Anonyma
Copy link
Contributor Author

Anonyma commented Mar 31, 2020

@RCheesley Done! I was using this list: http://www.editorialox.com/provinciasdeespana.htm and I didn't notice "Tenerife" was already added as "Santa Cruz de..."

Thank you for pointing it out 👍

@Anonyma Anonyma requested a review from RCheesley March 31, 2020 21:16
@npracht npracht changed the base branch from staging to 3.x April 4, 2020 17:13
@npracht npracht changed the base branch from 3.x to staging April 4, 2020 17:13
@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Apr 4, 2020
@npracht npracht modified the milestones: 3.0.1, 2.16.2 Apr 4, 2020
@dennisameling dennisameling changed the base branch from staging to 3.x April 4, 2020 18:26
@dennisameling dennisameling changed the base branch from 3.x to staging April 4, 2020 18:26
Copy link
Member

@dennisameling dennisameling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @Anonyma! Since this is a very small change that doesn't impact other Mautic code in any other way, I'm going ahead to approve this PR and merge it for 2.16.2.

@dennisameling dennisameling dismissed RCheesley’s stale review April 7, 2020 15:19

Fixed by PR author now

@dennisameling dennisameling merged commit 5847a9f into mautic:staging Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants