New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tenerife and Toledo to Spain regions #8608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Anonyma thanks so much for this PR!
Usually for PR's like this it is helpful to have a link to where the official regions can be found, as this helps maintainers to check against the official listings.
I guess this is the most appropriate/definitive list: https://en.wikipedia.org/wiki/Provinces_of_Spain
I noticed that we already have Santa Cruz de Tenerife on the list, so we don't want to add a duplication issue with this one. Let's remove the Tenerife entry for that reason.
Toledo is indeed missing so it should be added to this list!
If you can update your branch to remove the Tenerife entry we can then look to get this merged :)
@RCheesley Done! I was using this list: http://www.editorialox.com/provinciasdeespana.htm and I didn't notice "Tenerife" was already added as "Santa Cruz de..." Thank you for pointing it out 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @Anonyma! Since this is a very small change that doesn't impact other Mautic code in any other way, I'm going ahead to approve this PR and merge it for 2.16.2.
Please be sure you are submitting this against the staging branch.
Description: Added Tenerife and Toledo to Spain regions
Steps to reproduce the bug:
Steps to test this PR:
List deprecations along with the new alternative:
List backwards compatibility breaks: