Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded var dump in comment #8613

Merged
merged 1 commit into from Apr 6, 2020
Merged

Conversation

nickveenhof
Copy link
Contributor

We should not leave developer code in here :-)

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Yes
New feature? No
Automated tests included? Not needed
Related user documentation PR URL Not needed
Related developer documentation PR URL Not needed
Issues addressed (#s or URLs) Not needed
BC breaks? No
Deprecations? No

Description:

Removing unneeded comment

We should not leave developer code in here :-)
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nickveenhof and yes indeed, we should not be leaving this in the code - thanks for catching it and taking the time to fix it :)

@RCheesley RCheesley added code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality T1 Low difficulty to fix (issue) or test (PR) labels Apr 1, 2020
@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging T1 Low difficulty to fix (issue) or test (PR) labels Apr 2, 2020
@npracht npracht added this to the 2.16.2 milestone Apr 2, 2020
@dennisameling dennisameling merged commit 021acd8 into mautic:staging Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants