Fullcontact bundle api upgrade #8783

mohit-rocks · 2020-05-12T04:34:23Z

closes #8213
resolves #8079

Q	A
Bug fix?	Y
New feature?
Automated tests included?	N
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)	#8213
BC breaks?
Deprecations?

Description:

Steps to reproduce the bug:

Steps to test this PR:

Load up this PR

List deprecations along with the new alternative:

List backwards compatibility breaks:

Modify curl callback to include newly added authorization token.

TravisBuddy · 2020-05-12T04:53:42Z

Travis tests have failed

Hey @mohit-rocks,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8b992790-940c-11ea-95ad-2b40da7e2a04

TravisBuddy · 2020-05-20T16:43:40Z

Travis tests have failed

Hey @mohit-rocks,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0d3006e0-9ab9-11ea-ae6f-3d1c6927e18c

TravisBuddy · 2020-05-21T17:32:17Z

Travis tests have failed

Hey @mohit-rocks,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 02273450-9b89-11ea-acf2-2540bfc6cd37

…lated changes for the sync.

TravisBuddy · 2020-05-24T14:04:19Z

Travis tests have failed

Hey @mohit-rocks,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 74540ea0-9dc7-11ea-80ab-25118b76b5d1

TravisBuddy · 2020-05-26T18:57:34Z

Travis tests have failed

Hey @mohit-rocks,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c034c4b0-9f82-11ea-a34f-dd9ab62511aa

Added validation to check if key is set in value check. Remove redundant code in field mapping yaml.

TravisBuddy · 2020-05-27T16:57:54Z

Travis tests have failed

Hey @mohit-rocks,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 332d1a90-a03b-11ea-aa49-9d3926c79f60

TravisBuddy · 2020-05-27T17:14:21Z

Travis tests have failed

Hey @mohit-rocks,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7f31a2b0-a03d-11ea-aa49-9d3926c79f60

kuzmany · 2020-06-02T04:43:16Z

I did test.

1.I see this error: The following Mautic fields are required and must be mapped: Email
Cannot match fields in contact tab

Need support just sync to Mautic direction

TravisBuddy · 2020-06-11T14:19:07Z

Travis tests have failed

Hey @mohit-rocks,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8099f140-abee-11ea-a7dd-93c9ffbfb007

TravisBuddy · 2020-06-11T16:41:59Z

Travis tests have failed

Hey @mohit-rocks,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 75ba7f10-ac02-11ea-a7dd-93c9ffbfb007

kuzmany

I comment some parts to improve it
Also could we rework company fetch not by website, but by company name?
https://dashboard.fullcontact.com/api-ref#company-enrichment

plugins/MauticFullContactBundle/Sync/Mapping/Field/Field.php

kuzmany · 2020-06-11T21:09:53Z

plugins/MauticFullContactBundle/Sync/Mapping/FieldMappings/CompanyFieldMapping.yaml

+    displayName: "Name"
+    name: name
+    type: text
+-


Should add required: true to company name

kuzmany · 2020-06-11T21:10:07Z

plugins/MauticFullContactBundle/Sync/Mapping/FieldMappings/CompanyFieldMapping.yaml

+    displayName: "Email"
+    name: emails
+    type: text
+-


Should add required: true

This file is just to provide the mapping of source data field and mapping field.
Do we need to parse this attribute and add it on the configuration modal?

You have this attribute in Field.php DTO.
My suggestion make email/company name required and in the first place.

https://github.com/mautic/mautic/pull/8783/files#diff-b095ba0cad61c1b1c2ad02108d685e1cR22

Still small improvement.
Maybe email and company email as required.

stale · 2021-08-20T10:43:21Z

This issue or PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like to keep it open please let us know by replying and confirming that this is still relevant to the latest version of Mautic and we will try to get to it as soon as we can. Thank you for your contributions.

stale · 2021-09-03T12:40:24Z

This issue or PR has been automatically closed because it has not had recent activity. In the case of issues, if it persists in the latest version of Mautic, please create a new issue and link back to this one for reference. With PRs if you wish to pick up the PR and update it so that it can be considered for a future release, please comment and we will re-open it. Thank you for your contributions.

kuzmany

We use it in production.
Works 👍

kuzmany · 2021-10-12T13:27:59Z

@mohit-rocks can you resolve CS fixer?

mohit-rocks added 3 commits May 11, 2020 09:33

Added initial support for the integrations bundle.

911f2c6

Update full contact API calls as per the new API methods.

e39eabf

Update API callback to include key added in integraton configuration.

938422d

Modify curl callback to include newly added authorization token.

npracht added plugin Anything related to plugins needs-documentation PR's that need documentation before they can be merged T2 Medium difficulty to fix (issue) or test (PR) labels May 12, 2020

npracht added this to the 3.0.1 milestone May 12, 2020

Add integration suuport for company and contact bundles.

9b4aa80

Adding field mapping support for the data sync.

4cf96df

Implment contact storage service to store the contacts and perform re…

03b55d9

…lated changes for the sync.

mohit-rocks marked this pull request as draft May 24, 2020 16:25

mohit-rocks added 2 commits May 26, 2020 23:30

Implement contact sync and related changes.

10d393d

Added implementation for compnay lookup.

36532c1

mohit-rocks added 2 commits May 27, 2020 22:09

Fix the batch lookup process. Update the logo.

3460dff

Added validation to check if key is set in value check. Remove redundant code in field mapping yaml.

Fixing test case failures and update remaining todo items.

2c979a8

Add the email field in the sync options.

fe57068

mohit-rocks marked this pull request as ready for review June 11, 2020 16:18

mohit-rocks changed the title ~~[WIP] Fullcontact bundle api upgrade~~ Fullcontact bundle api upgrade Jun 11, 2020

Updating code to fix the PHP Rector issues.

3a87e15

kuzmany requested changes Jun 11, 2020

View reviewed changes

npracht modified the milestones: 3.2.3, 3.2.5, 3.3.1 Jan 15, 2021

npracht changed the base branch from staging to features January 19, 2021 16:20

RCheesley modified the milestones: 3.3.1, 3.3.2 Feb 23, 2021

RCheesley modified the milestones: 3.3.2, 3.3.3 Mar 15, 2021

Merge branch 'features' into fullcontact-bundle-api-upgrade

da6f360

RCheesley modified the milestones: 3.3.3, 4.0-beta Apr 16, 2021

npracht modified the milestones: 4.0-beta, 4.0-rc May 14, 2021

RCheesley removed this from the 4.0-rc milestone May 22, 2021

stale bot added the stale Issues which have not received an update within 90 days label Aug 20, 2021

stale bot closed this Sep 3, 2021

kuzmany reopened this Sep 3, 2021

stale bot removed the stale Issues which have not received an update within 90 days label Sep 3, 2021

RCheesley added the enhancement Any improvement to an existing feature or functionality label Sep 7, 2021

RCheesley changed the base branch from features to 4.x September 7, 2021 11:09

Merge branch '4.x' into fullcontact-bundle-api-upgrade

f252b7d

kuzmany previously approved these changes Oct 12, 2021

View reviewed changes

kuzmany added the pending-test-confirmation PR's that require one test before they can be merged label Oct 12, 2021

CS fix

aa396db

fedys dismissed kuzmany’s stale review via aa396db November 9, 2021 13:19

RCheesley added the needs-rebase PR's that need to be rebased label Aug 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fullcontact bundle api upgrade #8783

Fullcontact bundle api upgrade #8783

mohit-rocks commented May 12, 2020 •

edited by RCheesley

TravisBuddy commented May 12, 2020

TravisBuddy commented May 20, 2020

TravisBuddy commented May 21, 2020

TravisBuddy commented May 24, 2020

TravisBuddy commented May 26, 2020

TravisBuddy commented May 27, 2020

TravisBuddy commented May 27, 2020

kuzmany commented Jun 2, 2020

TravisBuddy commented Jun 11, 2020

TravisBuddy commented Jun 11, 2020

kuzmany left a comment

kuzmany Jun 11, 2020

kuzmany Jun 11, 2020

mohit-rocks Jun 14, 2020

kuzmany Jun 14, 2020

kuzmany Jun 25, 2020

stale bot commented Aug 20, 2021

stale bot commented Sep 3, 2021

kuzmany left a comment

kuzmany commented Oct 12, 2021

Fullcontact bundle api upgrade #8783

Are you sure you want to change the base?

Fullcontact bundle api upgrade #8783

Conversation

mohit-rocks commented May 12, 2020 • edited by RCheesley

Description:

Steps to reproduce the bug:

Steps to test this PR:

List deprecations along with the new alternative:

List backwards compatibility breaks:

TravisBuddy commented May 12, 2020

Travis tests have failed

TravisBuddy Request Identifier: 8b992790-940c-11ea-95ad-2b40da7e2a04

TravisBuddy commented May 20, 2020

Travis tests have failed

TravisBuddy Request Identifier: 0d3006e0-9ab9-11ea-ae6f-3d1c6927e18c

TravisBuddy commented May 21, 2020

Travis tests have failed

TravisBuddy Request Identifier: 02273450-9b89-11ea-acf2-2540bfc6cd37

TravisBuddy commented May 24, 2020

Travis tests have failed

TravisBuddy Request Identifier: 74540ea0-9dc7-11ea-80ab-25118b76b5d1

TravisBuddy commented May 26, 2020

Travis tests have failed

TravisBuddy Request Identifier: c034c4b0-9f82-11ea-a34f-dd9ab62511aa

TravisBuddy commented May 27, 2020

Travis tests have failed

TravisBuddy Request Identifier: 332d1a90-a03b-11ea-aa49-9d3926c79f60

TravisBuddy commented May 27, 2020

Travis tests have failed

TravisBuddy Request Identifier: 7f31a2b0-a03d-11ea-aa49-9d3926c79f60

kuzmany commented Jun 2, 2020

TravisBuddy commented Jun 11, 2020

Travis tests have failed

TravisBuddy Request Identifier: 8099f140-abee-11ea-a7dd-93c9ffbfb007

TravisBuddy commented Jun 11, 2020

Travis tests have failed

TravisBuddy Request Identifier: 75ba7f10-ac02-11ea-a7dd-93c9ffbfb007

kuzmany left a comment

Choose a reason for hiding this comment

kuzmany Jun 11, 2020

Choose a reason for hiding this comment

kuzmany Jun 11, 2020

Choose a reason for hiding this comment

mohit-rocks Jun 14, 2020

Choose a reason for hiding this comment

kuzmany Jun 14, 2020

Choose a reason for hiding this comment

kuzmany Jun 25, 2020

Choose a reason for hiding this comment

stale bot commented Aug 20, 2021

stale bot commented Sep 3, 2021

kuzmany left a comment

Choose a reason for hiding this comment

kuzmany commented Oct 12, 2021

mohit-rocks commented May 12, 2020 •

edited by RCheesley