Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lifecycle widget fatal error #8846

Merged
merged 1 commit into from Jun 11, 2020
Merged

Fix lifecycle widget fatal error #8846

merged 1 commit into from Jun 11, 2020

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented May 29, 2020

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC bdasdreaks?
Deprecations?

Description:

Minor fix to #8821

Steps to reproduce the bug:

  1. Add Lifecycle widget to dashboard

Steps to test this PR:

  1. Load up this PR
  2. Add Lifecycle widget to dashboard

List deprecations along with the new alternative:

List backwards compatibility breaks:

@kuzmany kuzmany added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test regression A bug that broke something in the last release labels May 29, 2020
@kuzmany kuzmany added this to the 3.0.0 milestone May 29, 2020
@kuzmany kuzmany mentioned this pull request May 29, 2020
Closed
@kuzmany kuzmany requested a review from RCheesley May 29, 2020 12:10
@RCheesley RCheesley linked an issue May 30, 2020 that may be closed by this pull request
Fatal error when adding lifecycle widget to dashboard #8821
Closed
RCheesley
RCheesley approved these changes May 30, 2020
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and fixes the bug 🚀

@RCheesley RCheesley added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels May 30, 2020
npracht
npracht approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code and it works better 🆒
👍

@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Jun 11, 2020
@npracht npracht added this to Done in Mautic 3 Jun 11, 2020
@dennisameling dennisameling merged commit a1cbf22 into mautic:3.x Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCheesley RCheesley RCheesley approved these changes

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged regression A bug that broke something in the last release
Projects
No open projects
Mautic 3
  
Done
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Fatal error when adding lifecycle widget to dashboard
4 participants
@kuzmany @RCheesley @npracht @dennisameling