Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Amazon port form 2587 to 587 #9218

Closed
wants to merge 1 commit into from

Conversation

LevryKurniawan
Copy link
Contributor

@LevryKurniawan LevryKurniawan commented Sep 20, 2020

Q A
Branch? 3.1
Bug fix? yes
New feature? no
Deprecations? no
BC breaks? no
Automated tests included? no
Issue(s) addressed Fixes #9212

Description:

This was changed from 587 to 2587 by #3857.
But due to the above issue and Google Cloud has also open port 587, I think it is necessary to bring it back to 587.

Steps to test this PR:

  1. Load up this PR

@cla-bot
Copy link

cla-bot bot commented Sep 20, 2020

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact @RCheesley. CLA has not been signed by @LevryKurniawan.

@LevryKurniawan LevryKurniawan changed the base branch from staging to 3.1 September 20, 2020 05:36
@RCheesley
Copy link
Sponsor Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Sep 21, 2020
@cla-bot
Copy link

cla-bot bot commented Sep 21, 2020

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break the integration, SES SMTP defaults to the port 2587 and webhooks coming back from SNS are request back to HTTP or HTTPS ports.

I think this PR is not relevant to the issue described

@RCheesley
Copy link
Sponsor Member

Hi @LevryKurniawan and thanks for taking the time to make this PR.

Generally speaking, the reason why the port you initially tried to use will not work is because your firewall is blocking it at the server level. The appropriate course of action would be to open the port so that you are able to connect on the default port.

As this is a server configuration issue we would not look to introduce this proposed change, so I will close this PR down.

@RCheesley RCheesley closed this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The PR contributors have signed the contributors agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I fixed a bug but I dont know how too Committ - Amazon SNS Notification Bug
3 participants