Segment categories #9544

bkomel · 2020-12-29T16:27:12Z

Q	A
Branch?	features
Bug fix?	no
New feature?	yes
Deprecations?	no
BC breaks?	no
Automated tests included?	no
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed

Description:

This feature allows users to add new categories of type 'segment' and sort segments (lead lists) into this categories. When listing the segments it is possible to filter them based on the category.

Steps to test this PR:

Load up this PR
Create a new category of type 'segment' and name it Segment Category 1.
Go to segments and create a new segment named Segment 1. Select the category created in previous step.
Create a new uncategorized segment named Segment 2.
In Segments click on the 'Segment Category Filter' in the toolbar and select Segment Category 1.
Now only Segment 1 is listed.

This reverts commit a0383d0.

This reverts commit a1fc189.

cla-bot · 2020-12-29T16:27:14Z

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @bkomel.

kuzmany

Looks good. Please add migrations

app/bundles/LeadBundle/DataFixtures/ORM/LoadCategorizedLeadListData.php

RCheesley · 2021-01-06T13:39:58Z

@cla-bot check

… keys in CategoryModel getLookupResults method.

… var global0,segment0 keys in CategoryModel getLookupResults method

This reverts commit a0383d0.

This reverts commit a1fc189.

dennisameling

Code is looking great, thanks @bkomel! I tested the migration locally and it works without issues. Nice that you even included a down() function 🚀 Since this has been tested by multiple people already, I'll go ahead and merge this PR now 😊

Solved by PR author

dennisameling · 2021-02-13T22:48:07Z

This PR is breaking the API library tests unfortunately: https://github.com/mautic/api-library/actions/runs/562027599

Will have a closer look tomorrow.

Note to self: I think it's caused by the fact that it adds a dependency to the CategoryModel in the ListModel. The CategoryModel is dependent on the BrowserStack for getting the current request 🤯 - ~~will have a closer look tomorrow, brain is tired 😅~~

UPDATE: Bingo! Found a solution. CategoryModel's constructor shouldn't try to get the current request already in the constructor, since it's null at that point. I think I've come across this before, so I want to fix this in more places once and for all. To be continued.

dennisameling · 2021-02-14T16:03:31Z

Fixed in #9667

bkomel added 20 commits December 29, 2020 15:01

segment key under categories in LeadBundle config file

a0383d0

Revert "segment key under categories in LeadBundle config file"

d3bfa90

This reverts commit a0383d0.

segment key under categories in LeadBundle config file

a1fc189

Revert "segment key under categories in LeadBundle config file"

a80ffcb

This reverts commit a1fc189.

segment key under categories in LeadBundle config file

937adbf

Segment category type(bundle) choice translation

1260f9f

Test whether the option for a segment type category is available

cd45d3b

add category to LeadList Entity

cde879e

add categoryListType field to List Form

0d0abff

show category field in leadlist form view

dcbb3c7

test adding a new categorized lead list

bad6d2f

register LoadCategoryData fixture

9e7e4a4

fakecategorydata csv and its fixture

964d032

inject category model to ListModel

0d33911

getIndexItems method overwrite

b6d391f

use getIndexItems, getViewParameters to add list category filter

d35f78b

getSourceLists method in ListModel

4b9f9fe

category filter in list_toolbar, corresponding translations

44f232f

categorizedLeadListData test fake data and fixtures

9729395

test retrieval of categorized lists

f1d5520

npracht added categories Anything related to categories feature A new feature for inclusion in minor or major releases segments Anything related to segments needs-automated-tests PR's that need automated tests before they can be merged ready-to-test PR's that are ready to test labels Dec 29, 2020

npracht added this to the 3.3 milestone Dec 29, 2020

kuzmany previously requested changes Dec 29, 2020

View reviewed changes

app/bundles/LeadBundle/DataFixtures/ORM/LoadCategorizedLeadListData.php Outdated Show resolved Hide resolved

cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Jan 6, 2021

bkomel and others added 17 commits January 27, 2021 08:33

remove in foreach, change year in description

6b08946

1st test to make request on /s/segments/new, setting static array var…

12b9e18

… keys in CategoryModel getLookupResults method.

event, set new categorized list

9fa6681

lead_lists category_id column, constraint, index migration

2c6e2ad

ListModelTest, testGetSourceLists method

45ed5fe

EmailApiControllerFunc test testSingleEmailWorkflow sets static array…

5ac0208

… var global0,segment0 keys in CategoryModel getLookupResults method

Revert "segment key under categories in LeadBundle config file"

a1d9f23

This reverts commit a0383d0.

segment key under categories in LeadBundle config file

7757e53

Revert "segment key under categories in LeadBundle config file"

a8007ed

This reverts commit a1fc189.

segment key under categories in LeadBundle config file

d2ca28b

register LoadCategoryData fixture

f798c6c

inject category model to ListModel

6d3ee99

categorizedLeadListData test fake data and fixtures

63ff308

added requestStack to mockListModel

935e689

remove return string

a307adc

return types, function arguments types

3e43ce7

Merge branch 'features' into segment-categories

023e599

bkomel requested a review from dennisameling January 27, 2021 13:20

dennisameling approved these changes Jan 27, 2021

View reviewed changes

dennisameling removed the pending-feedback PR's and issues that are awaiting feedback from the author label Jan 27, 2021

dennisameling merged commit c0c6add into mautic:features Jan 27, 2021

dennisameling added the needs-documentation PR's that need documentation before they can be merged label Jan 27, 2021

dennisameling mentioned this pull request Jan 27, 2021

New feature: segment categories TEDU-58 mautic/mautic-documentation#165

Open

dennisameling mentioned this pull request Feb 14, 2021

Avoid using requestStack->getCurrentRequest() in constructor #9667

Merged

This was referenced Feb 23, 2021

Migrations failed when upgrading to 3.3 #9709

Closed

Fix migration for 3.3.0 #9718

Closed

Fix migration for 3.3.0 #9720

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Segment categories #9544

Segment categories #9544

bkomel commented Dec 29, 2020 •

edited by npracht

cla-bot bot commented Dec 29, 2020

kuzmany left a comment

RCheesley commented Jan 6, 2021

dennisameling left a comment •

edited

dennisameling commented Feb 13, 2021 •

edited

dennisameling commented Feb 14, 2021

Segment categories #9544

Segment categories #9544

Conversation

bkomel commented Dec 29, 2020 • edited by npracht

Description:

Steps to test this PR:

cla-bot bot commented Dec 29, 2020

kuzmany left a comment

Choose a reason for hiding this comment

RCheesley commented Jan 6, 2021

dennisameling left a comment • edited

Choose a reason for hiding this comment

dennisameling commented Feb 13, 2021 • edited

dennisameling commented Feb 14, 2021

bkomel commented Dec 29, 2020 •

edited by npracht

dennisameling left a comment •

edited

dennisameling commented Feb 13, 2021 •

edited