New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for builder specific templates #9654
Support for builder specific templates #9654
Conversation
…rts the given feature
…visible when a builder plugin is installed)
Codecov Report
@@ Coverage Diff @@
## features #9654 +/- ##
==============================================
+ Coverage 38.33% 38.35% +0.01%
- Complexity 33939 33957 +18
==============================================
Files 1982 1984 +2
Lines 104948 104997 +49
==============================================
+ Hits 40236 40274 +38
- Misses 64712 64723 +11
|
…e of duplicating internal state results when calling getInstalledThemes multiple times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as describe.
Good job
found that it looks like when you edit an existing resource, you can make changes and save them, however the wrong template will show in the dropdown because the one that was used originally is not available (assuming they did not add the line in the config file for the template). We need to document this if that is the case and make sure that people are aware, before they start working with the builder.
This is weird, but I think older templates are editable in grapejs in good way.
Still this is better like previous state, and we can improve it later...
Description:
This enables plugins to identify itself as providing a "builder" integration. Mautic will then filter themes based on the builder that is enabled (will only acknowledge the first one it finds if there happens to be multiple for a given feature).
Companion PR for the GrapeJS plugin is here mautic/plugin-grapesjs-builder#42.
Steps to test this PR:
"builder": "grapesjsbuilder"
to the json objectGrapesJS
.