Segment email send to email address just once #9781
Conversation
kuzmany
added
WIP
cla-bot
bot
added
the
cla-signed
Codecov Report
@@ Coverage Diff @@
## 4.x #9781 +/- ##
============================================
- Coverage 48.21% 47.86% -0.35%
+ Complexity 35275 35206 -69
============================================
Files 2125 2120 -5
Lines 105200 118329 +13129
============================================
+ Hits 50719 56642 +5923
- Misses 54481 61687 +7206
|
RCheesley
added
the
has-conflicts
Damzoneuh
force-pushed
the
segment-email-send-to-email-address-once
branch
from
a4c0d6d
to
dd2d383
Compare
Damzoneuh
force-pushed
the
segment-email-send-to-email-address-once
branch
from
dd2d383
to
643f44a
Compare
kuzmany
added
ready-to-test
|
This issue or PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like to keep it open please let us know by replying and confirming that this is still relevant to the latest version of Mautic and we will try to get to it as soon as we can. Thank you for your contributions. |
|
This issue or PR has been automatically closed because it has not had recent activity. In the case of issues, if it persists in the latest version of Mautic, please create a new issue and link back to this one for reference. With PRs if you wish to pick up the PR and update it so that it can be considered for a future release, please comment and we will re-open it. Thank you for your contributions. |
stale
bot
removed
the
stale
kuzmany
added
pending-test-confirmation
…o-email-address-once # Conflicts: # app/bundles/EmailBundle/Translations/en_US/messages.ini
|
@kuzmany could you plz update this? I'll test immediately and it could be merged. |
# Conflicts: # app/bundles/EmailBundle/Tests/Model/EmailModelFunctionalTest.php
|
@jos0405 done |
jos0405
added
ready-to-commit
There was a problem hiding this comment.
There is a failing test:
There was 1 error:
1) Mautic\EmailBundle\Tests\Model\EmailModelFunctionalTest::testSendEmailToTwoSameEmailAddressWithOptionSegmentEmailOnceToEmailAddress
LogicException: You cannot re-create the client when a transaction rollback for cleanup is enabled. Turn it off using $useCleanupRollback property or avoid re-creating a client.
/home/runner/work/mautic/mautic/app/bundles/CoreBundle/Test/MauticMysqlTestCase.php:85
/home/runner/work/mautic/mautic/app/bundles/EmailBundle/Tests/Model/EmailModelFunctionalTest.php:106
phpvfscomposer:///home/runner/work/mautic/mautic/vendor/phpunit/phpunit/phpunit:97
|
|
||
| self::assertEquals(2, $sentCount, $email->getCustomHtml()); | ||
|
|
||
| $this->connection->executeQuery("SET GLOBAL sql_mode=(SELECT REPLACE(@@sql_mode,'ONLY_FULL_GROUP_BY',''))"); |
There was a problem hiding this comment.
Why is this here? I think that's why the transaction rollback fails.
escopecz
added
the
pending-feedback
Co-authored-by: John Linhart <jan@linhart.email>
Description:
Our client want use contacts with same email address, but avoid send more times to that email address, even If contact's are in segments. For example If more employees use same email address, or family use one email address for parents and children.
This PR added new configuration parameter to enable avoid send segment email to more like one unique email address.
Steps to test this PR:
Load up this PR
Create segment
Create 3 contacts with same email@domain.tld and add them to segment
Create segment email
Go to configuration and enable new options - Send to duplicated just once
Send segment email
See just one email you receive