Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing deprecated at() calls in unit tests #9835

Merged
merged 20 commits into from
Mar 27, 2021

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented Mar 26, 2021

Q A
Branch? "features"
Bug fix? yes/no
New feature? yes/no
Deprecations? no
BC breaks? no
Automated tests included? yes
Related user documentation PR URL /
Related developer documentation PR URL /
Issue(s) addressed https://mautic.atlassian.net/browse/TPROD-161

Description:

After the PHPUNIT upgrade our test reports were showing warning in many tests. This PR refactors the tests that were using at() method to something else to get cleaner test reports.

Steps to test this PR:

  1. There was no change in the production code. So just check the GitHub Actions phpunit report.

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Mar 26, 2021
@escopecz escopecz added the WIP PR's that are not ready for review and are currently in progress label Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #9835 (2e7770e) into features (c3e2676) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             features    #9835      +/-   ##
==============================================
+ Coverage       39.64%   39.66%   +0.02%     
  Complexity      33978    33978              
==============================================
  Files            1989     1989              
  Lines          105730   105731       +1     
==============================================
+ Hits            41913    41943      +30     
+ Misses          63817    63788      -29     
Impacted Files Coverage Δ Complexity Δ
...Bundle/EventListener/DetermineWinnerSubscriber.php 86.44% <100.00%> (ø) 21.00 <1.00> (ø)
...DashboardBundle/Controller/DashboardController.php 32.82% <100.00%> (+0.25%) 60.00 <0.00> (ø)
...Bundle/EventListener/DetermineWinnerSubscriber.php 80.90% <100.00%> (ø) 32.00 <1.00> (ø)
...ce/DeviceTrackingService/DeviceTrackingService.php 88.13% <100.00%> (ø) 18.00 <5.00> (ø)
...les/EmailBundle/EventListener/ReportSubscriber.php 33.81% <0.00%> (+0.29%) 49.00% <0.00%> (ø%)
...eadBundle/EventListener/ReportUtmTagSubscriber.php 92.85% <0.00%> (+3.57%) 9.00% <0.00%> (ø%)
app/bundles/FormBundle/Helper/FormUploader.php 60.81% <0.00%> (+13.51%) 24.00% <0.00%> (ø%)
app/bundles/CoreBundle/Helper/FilePathResolver.php 100.00% <0.00%> (+13.51%) 14.00% <0.00%> (ø%)
app/bundles/FormBundle/Crate/FileFieldCrate.php 100.00% <0.00%> (+57.14%) 3.00% <0.00%> (ø%)
app/bundles/FormBundle/Crate/UploadFileCrate.php 83.33% <0.00%> (+66.66%) 6.00% <0.00%> (ø%)

@escopecz escopecz changed the title Replacing deprecated at() calls part 1 Replacing deprecated at() calls in unit tests Mar 26, 2021
@escopecz escopecz added automated-tests Anything related to unit, functional or e2e tests ready-to-test PR's that are ready to test and removed WIP PR's that are not ready for review and are currently in progress labels Mar 26, 2021
@RCheesley RCheesley added chore Tasks that relate to maintaining this Github repository CI Anything related to CI (Continuous Integration) and removed chore Tasks that relate to maintaining this Github repository labels Mar 26, 2021
Copy link
Member

@dennisameling dennisameling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John, I'm speechless. This is incredible and impressive. Thank you SO much for working on this! Highly appreciated 🧙🏼 🚀

giphy 1

@dennisameling dennisameling added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test labels Mar 26, 2021
@dennisameling dennisameling added this to the Mautic 4.0 milestone Mar 26, 2021
@dennisameling dennisameling merged commit 21cc28b into mautic:features Mar 27, 2021
@RCheesley RCheesley added the bug Issues or PR's relating to bugs label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated-tests Anything related to unit, functional or e2e tests bug Issues or PR's relating to bugs CI Anything related to CI (Continuous Integration) cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants