-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing deprecated at() calls in unit tests #9835
Merged
dennisameling
merged 20 commits into
mautic:features
from
escopecz:replacing-phpunit-at
Mar 27, 2021
Merged
Replacing deprecated at() calls in unit tests #9835
dennisameling
merged 20 commits into
mautic:features
from
escopecz:replacing-phpunit-at
Mar 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## features #9835 +/- ##
==============================================
+ Coverage 39.64% 39.66% +0.02%
Complexity 33978 33978
==============================================
Files 1989 1989
Lines 105730 105731 +1
==============================================
+ Hits 41913 41943 +30
+ Misses 63817 63788 -29
|
dennisameling
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automated-tests
Anything related to unit, functional or e2e tests
bug
Issues or PR's relating to bugs
CI
Anything related to CI (Continuous Integration)
cla-signed
The PR contributors have signed the contributors agreement
ready-to-commit
PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
After the PHPUNIT upgrade our test reports were showing warning in many tests. This PR refactors the tests that were using
at()
method to something else to get cleaner test reports.Steps to test this PR: