changes to encoder to update to Symfony #9842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mabumusa1
added
bug
|
For reference this article included the changes required http://securepasswords.info/symfony/ |
Codecov Report
@@ Coverage Diff @@
## features #9842 +/- ##
===========================================
Coverage 39.66% 39.66%
Complexity 33978 33978
===========================================
Files 1989 1989
Lines 105731 105731
===========================================
Hits 41943 41943
Misses 63788 63788
|
RCheesley
approved these changes
Mar 28, 2021
There was a problem hiding this comment.
Bug reproduced and the PR applied fixes the issue - was able to create a new user and to log in as that user with the correct access rights! Thanks @mabumusa1 🚀
RCheesley
added
the
pending-test-confirmation
escopecz
reviewed
Mar 28, 2021
| @@ -21,7 +21,7 @@ | |||
| use Symfony\Component\HttpFoundation\JsonResponse; | |||
| use Symfony\Component\HttpFoundation\Response; | |||
| use Symfony\Component\HttpKernel\Event\FilterControllerEvent; | |||
| use Symfony\Component\Security\Core\Encoder\PasswordEncoderInterface; | |||
| use Symfony\Component\Security\Core\Encoder\UserPasswordEncoder; | |||
There was a problem hiding this comment.
This use statement is not used anywhere and can be removed. This is just a nitpick, nothing that should block the PR merge.
escopecz
approved these changes
Mar 28, 2021
escopecz
added
ready-to-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Steps to test this PR: