Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if form calls IsSubmitted #9847

Merged
merged 4 commits into from
Mar 29, 2021

Conversation

mabumusa1
Copy link
Member

Q A
Branch? "features"
Bug fix? yes
New feature? no
Deprecations? no
BC breaks? no
Automated tests included? yes/no
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #9826

Description:

Steps to test this PR:

  1. Load up this PR

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Mar 28, 2021
@mabumusa1 mabumusa1 self-assigned this Mar 28, 2021
@mabumusa1 mabumusa1 added this to the Mautic 4.0 milestone Mar 28, 2021
@mabumusa1 mabumusa1 added bug Issues or PR's relating to bugs companies Anything related to companies mautic-4 Relates to Mautic 4.x T1 Low difficulty to fix (issue) or test (PR) themes Anything related to themes labels Mar 28, 2021
RCheesley
RCheesley previously approved these changes Mar 28, 2021
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the bug before applying the PR - 500 error. After applying the PR I was able to merge the two companies without an error and the contacts are correctly assigned to the company as a result. Thanks @mabumusa1 ! 🚀 🎉

@RCheesley RCheesley added the pending-test-confirmation PR's that require one test before they can be merged label Mar 28, 2021
@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #9847 (fc81f71) into features (cf0cd31) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             features    #9847   +/-   ##
===========================================
  Coverage       39.77%   39.77%           
- Complexity      34196    34197    +1     
===========================================
  Files            2017     2017           
  Lines          106372   106372           
===========================================
  Hits            42313    42313           
  Misses          64059    64059           
Impacted Files Coverage Δ Complexity Δ
...s/CoreBundle/Controller/AbstractFormController.php 9.00% <100.00%> (ø) 33.00 <0.00> (+1.00)

@escopecz escopecz added the pending-feedback PR's and issues that are awaiting feedback from the author label Mar 28, 2021
Co-authored-by: John Linhart <jan@linhart.email>
@mabumusa1 mabumusa1 removed the pending-feedback PR's and issues that are awaiting feedback from the author label Mar 29, 2021
Copy link
Sponsor Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@RCheesley RCheesley merged commit 9e2f5fe into mautic:features Mar 29, 2021
@RCheesley
Copy link
Sponsor Member

@all-contributors add mabumusa1 for code

@allcontributors
Copy link
Contributor

@RCheesley

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 325

@RCheesley
Copy link
Sponsor Member

@all-contributors add mabumusa1 for code

@allcontributors
Copy link
Contributor

@RCheesley

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 355

@RCheesley
Copy link
Sponsor Member

RCheesley commented Mar 29, 2021

@all-contributors add @mabumusa1 for code

@allcontributors
Copy link
Contributor

@RCheesley

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 355

@RCheesley
Copy link
Sponsor Member

@all-contributors add @mabumusa1 for code

@allcontributors
Copy link
Contributor

@RCheesley

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token { in JSON at position 358

@RCheesley
Copy link
Sponsor Member

@all-contributors add @mabumusa1 for code

@allcontributors
Copy link
Contributor

@RCheesley

I've put up a pull request to add @mabumusa1! 🎉

@mabumusa1 mabumusa1 deleted the fix_9826_form_submitted branch April 3, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement companies Anything related to companies mautic-4 Relates to Mautic 4.x pending-test-confirmation PR's that require one test before they can be merged T1 Low difficulty to fix (issue) or test (PR) themes Anything related to themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mautic 4: Unable to merge companies
3 participants