Fix ConsoleErrorListener #9850
Merged
Fix ConsoleErrorListener #9850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Codecov Report
@@ Coverage Diff @@
## features #9850 +/- ##
==============================================
+ Coverage 39.66% 39.68% +0.01%
- Complexity 33978 33979 +1
==============================================
Files 1989 1989
Lines 105731 105731
==============================================
+ Hits 41943 41955 +12
+ Misses 63788 63776 -12
|
RCheesley
approved these changes
Mar 29, 2021
dennisameling
commented
Mar 29, 2021
| @@ -38,6 +38,7 @@ | |||
| <env name="MAXMIND_LICENSE_KEY" value=""/> | |||
| <env name="KERNEL_CLASS" value="AppKernel" /> | |||
| <const name="IS_PHPUNIT" value="true"/> | |||
| <const name="MAUTIC_ENV" value="test"/> | |||
There was a problem hiding this comment.
This prevents us from having to set it in single tests that need it (ConsoleErrorListener needs it)
|
@all-contributors please add @dennisameling for code and @RCheesley for userTesting |
|
I've put up a pull request to add @dennisameling! 🎉 |
|
@all-contributors please add @RCheesley for userTesting |
|
I've put up a pull request to add @RCheesley! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #9848 by simply checking if an
$commandobject is not null (in the reported case it was null)Steps to test this PR: