Move Email config / DSN settings to Configuration section #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCheesley
commented
Jun 27, 2023
| @@ -161,6 +161,114 @@ Campaign settings | |||
| Email settings | |||
| ************** | |||
|
|
|||
| Email transport settings | |||
There was a problem hiding this comment.
@escopecz I figured that email transport settings might be a more accurate heading, WDYT?
escopecz
previously approved these changes
Jun 28, 2023
|
@RCheesley can we merge this? @fedys could use this as a base for the queue setting docs. |
|
Another question, shouldn't this be against the 5.x branch? |
RCheesley
force-pushed
the
refactor-email-dsn-info
branch
from
f94fdad
to
c7b70cf
Compare
|
Ah yeah thanks for that @escopecz ... I smooshed up the rebase but think it's fixed now. The outstanding vale issues are warnings/notices which are not relevant in my opinion so we should be OK to go with this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the configuration for the email settings / DSN over to the email config part, where it should really live.
I also fixed a ton of incorrect apostrophes which is common when copy/pasting from another source.