Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for shortener services #191

Merged
merged 13 commits into from
Jan 9, 2024
Merged

Add support for shortener services #191

merged 13 commits into from
Jan 9, 2024

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Jul 28, 2023 •
edited by gitpod-io bot
Loading

@kuzmany kuzmany changed the title Rename .readthedocs.yaml to readthedocs.yaml Add support for shortener services Jul 28, 2023
@kuzmany kuzmany mentioned this pull request Jul 28, 2023
Merged
RCheesley
RCheesley requested changes Aug 4, 2023
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing the docs for this @kuzmany - some suggested changes based on our style guide. Let me know if you need any help with any of it!

docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
@RCheesley
Copy link
Sponsor Member

@kuzmany this needs rebasing onto 5.x please, and the suggestions addressing. Thanks!

kuzmany and others added 6 commits October 24, 2023 20:35
@kuzmany @RCheesley
Update docs/configuration/shortener.rst
21716e1 
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
@kuzmany @RCheesley
Update docs/configuration/shortener.rst
11b085b 
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
@kuzmany @RCheesley
Update docs/configuration/shortener.rst
099ffc5 
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
@kuzmany @RCheesley
Update docs/configuration/shortener.rst
b8c7d44 
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
@kuzmany @RCheesley
Apply suggestions from code review
d9ea5cc 
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
@RCheesley
Merge branch 'main' into shortener-service-support
8b9c124
@RCheesley RCheesley changed the base branch from main to 5.x January 9, 2024 18:29
RCheesley
RCheesley requested changes Jan 9, 2024
View reviewed changes
Copy link
Sponsor Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - some changes required.

docs/configuration/shortener.rst Outdated Show resolved Hide resolved
docs/configuration/shortener.rst Outdated Show resolved Hide resolved
@RCheesley
Copy link
Sponsor Member

GTG! 🚀

@RCheesley RCheesley merged commit 112d11f into mautic:5.x Jan 9, 2024
2 checks passed
@RCheesley RCheesley mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RCheesley RCheesley RCheesley requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuzmany @RCheesley