Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #200

Merged
merged 10 commits into from
Mar 31, 2024
Merged

Development #200

merged 10 commits into from
Mar 31, 2024

Conversation

trek-boldly-go
Copy link
Collaborator

  • Sent and received edited messages (Bluebubbles Server 1.9.6 required) ✅
  • Sent and received "unsent" messages (Bluebubbles Server 1.9.6 required) ✅
  • Received read receipts ✅
  • Websocket recovery process leak ✅
  • Improved backfilling code (BB Server wasn't filtering by ChatID in original endpoint) ✅
  • Add fallback identifier if not found in BB search ✅

Co-authored-by: Donovon Simpson <66212896+trek-boldly-go@users.noreply.github.com>
Copy link
Collaborator

@cnuss cnuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything in api.go looks good to me!

deferring to @tulir for final approval since there were edits to non bluebubbles code

ROADMAP.md Show resolved Hide resolved
ROADMAP.md Show resolved Hide resolved
portal.go Outdated Show resolved Hide resolved
portal.go Show resolved Hide resolved
portal.go Outdated Show resolved Hide resolved
portal.go Show resolved Hide resolved
portal.go Outdated Show resolved Hide resolved
portal.go Outdated Show resolved Hide resolved
portal.go Show resolved Hide resolved
Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine other than the linter errors

@cameronaaron
Copy link
Contributor

I fixed the lint error in #206 please merge it in and all should be good in the world

@trek-boldly-go trek-boldly-go merged commit bae4fc5 into master Mar 31, 2024
11 checks passed
@trek-boldly-go trek-boldly-go deleted the development branch March 31, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants