add support for kick/ban/unban #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltee1
commented
May 10, 2022
tulir
reviewed
May 17, 2022
Co-authored-by: Tulir Asokan <tulir@maunium.net>
tulir
reviewed
May 30, 2022
Co-authored-by: Tulir Asokan <tulir@maunium.net>
Co-authored-by: Tulir Asokan <tulir@maunium.net>
tulir
requested changes
Jun 17, 2022
Co-authored-by: Tulir Asokan <tulir@maunium.net>
tulir
reviewed
Jun 17, 2022
tulir
approved these changes
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work just fine.
We might have to think about power levels for kicking/banning/unbanning, because on signal, an
ADMINISTRATORcan perform those actions on anotherADMINISTRATOR, whereas matrix does not allow this if power levels are the same. I was thinking we could give a power level of 51 to matrix users, so they will be able to kick puppets, while Signal users can kick matrix users through the bridge bot.