use group change #283
Merged
use group change #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltee1
force-pushed
the
use_groupchange
branch
4 times, most recently
from
c84051a
to
dd2f6fc
Compare
maltee1
force-pushed
the
use_groupchange
branch
3 times, most recently
from
fa2d31d
to
93a06ac
Compare
tulir
reviewed
Jul 17, 2022
Co-authored-by: Tulir Asokan <tulir@maunium.net>
maltee1
force-pushed
the
use_groupchange
branch
2 times, most recently
from
1fa4e9d
to
b777c24
Compare
tulir
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the GroupChange instead of scanning the group info for changes. This should be more efficient and also makes it easier to bridge changes with correct sender metadata. It will also avoid the issue of a particular change being wrongfully bridged as coming from a particular user when a previous change was missed (due to the bridge being down for example).
This should allow removing sender info from
update_infoand most of the functions it calls, but I haven't done that yet, because those would mean a lot of changes in a lot of places. I would also incorporate theGroupV2IDtype intoGroupV2. So far I have only incorporated minimal changes into the rest of the code to make it work with the new additions. The aforementioned changes are better saved for another PR or another commit.This might make part of #275 obsolete, so maybe this one should be merged first.