don't kick ghost on GroupPatchNotAcceptedError if they are in the signal group #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltee1
force-pushed
the
failed_invite_check_members
branch
from
49dacd0
to
b36b8cb
Compare
tulir
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bridge used to kick newly invited signal ghosts upon error, even if that error just meant that they already are in the group.
I encountered that error when testing the mautrix-python PR. When the group is created, all users in the room at that moment are added to the group, invites that have gone through on the matrix side at the time of group creation will produce a GroupPatchNotAcceptedError. The bridge should not kick the user if they are confirmed to be in the group.