Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly convert signal long text messages #506

Merged
merged 1 commit into from
May 1, 2024
Merged

Properly convert signal long text messages #506

merged 1 commit into from
May 1, 2024

Conversation

maltee1
Copy link
Contributor

@maltee1 maltee1 commented Apr 23, 2024

Fixes #479

tulir
tulir approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it might work, although I think there were also some edge cases with text formatting

@maltee1
Copy link
Contributor Author

maltee1 commented Apr 24, 2024

Formatting works with this

@tulir tulir merged commit 73e7619 into mautrix:main May 1, 2024
4 checks passed
@maltee1 maltee1 deleted the download_x_signal_plain branch May 1, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long messages are sent as m.file with part of the message as body
2 participants
@maltee1 @tulir