New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TGS animation support #366
Conversation
XXX: there is the bug in tgs lib, it crashes on some tgs files. Also cairo svg2png need to be called not from tgs.exporters because there is no option to set image size
…h supports resize. XXX: videos don't want to be played by riot, i don't know why...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great. The performance is a bit of a concern (see third thread comment), but it should be solvable
Co-Authored-By: Tulir Asokan <tulir@maunium.net>
Deleted autogenerated header and set licence
@Eramde is this ready? |
@tulir Sorry forgot about notification. Yep, i fixed propblematic places and utility can now export to png sequence with defined framerate, so there won't any problems with animation speed when ffmpeg is used. I discarded using bash script and call ffmpeg process from python, i thing this is better. |
Yeah, the script is only needed if it needs 100 calls. If it's just one or two, it's better to do from python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little changes to build converter script (using release conf) (see here)
@Eramde building with the release conf seems to make the webm conversion fail with a lottieconverter error and exit code -11 |
Sounds strange, because Debug and Release builds differs only g++ build keys (-g vs -O2), and memtest does not show any possible problems (-11 exit code is probably segfault). Could you, please provide input file to check? |
is there a guide somewhere how to use this? |
Hello. Just build utility, place it into one of $PATH's folder (i.e. /usr/bin) or python's venv/bin and set configuration. I don't exactly know if @tulir 's docker image already has utility... |
Fixes #340
Added tgs file converter.
Converts animations using external utility, which uses Samsung/rlottie library.
So to get it work, utility and libraries are also needed in the system or in venv.
I tried to use tgs library but it generates very... strange images (with a lot of artifacts).