Added Travis file for CI #26
Conversation
| @@ -31,6 +31,7 @@ set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g") | |||
| set(CMAKE_CXX_FLAGS_MINSIZEREL "-Os -DNDEBUG") | |||
| set(CMAKE_CXX_FLAGS_RELEASE "-O3 -DNDEBUG") | |||
| set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g") | |||
| set(CMAKE_EXE_LINKER_FLAGS "-pthread") | |||
There was a problem hiding this comment.
Can you try whether this more portable fix works as well?
# Exists already.
find_package(Threads)
if (NOT Threads_FOUND)
message(FATAL_ERROR "Could not find system threading libraries")
endif ()
# Add this line.
target_link_libraries(libbf ${CMAKE_THREAD_LIBS_INIT})
There was a problem hiding this comment.
CMake Error at CMakeLists.txt:44 (target_link_libraries):
Cannot specify link libraries for target "libbf" which is not built by this
project.
There was a problem hiding this comment.
I forgot: this line needs go below after add_library. (line 85)
test/unit_test_impl.hpp
Outdated
| @@ -333,7 +333,14 @@ bool engine::run(bool colorize, | |||
| // psv == pipe-separated-values | |||
| strvec result; | |||
| if (psv != ".*") { | |||
| split(result, psv, "|", token_compress_on); | |||
| // Quick & dirty fix | |||
There was a problem hiding this comment.
The comment makes only sense in the diff, so I'd either comment the previous line or remove the comment entirely.
test/unit_test_impl.hpp
Outdated
| // Quick & dirty fix | ||
| std::istringstream ss(psv); | ||
| std::string token; | ||
| while(std::getline(ss, token, ',')) { |
There was a problem hiding this comment.
Style:
- space around keywords
- omit braces for single-line statements
Ideally we can use this clang-format style: https://github.com/actor-framework/actor-framework/blob/develop/.clang-format.
There was a problem hiding this comment.
I can set up an automatic style validator for PRs.
amallia
force-pushed
the
travis
branch
5 times, most recently
from
7ac0e8b
to
cb897e0
Compare
|
I've pushed some lingering local changes to master. You should be able to safely rebase your topic branch. |
@mavam for review