Refold from caseygoodhew/grunt-cucumber #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t tasks from running
caseygoodhew
commented
May 9, 2017
| @@ -184,10 +184,8 @@ module.exports = function(grunt) { | |||
| handler(grunt, options, commands, function handlerCallback(err) { | |||
| if (err) { | |||
| grunt.log.error('failed tests, please see the output'); | |||
There was a problem hiding this comment.
Invoking done(false) causes the grunt task to report a failure, which probably isn't the desired intention here - failed tests should not result in a failed grunt task.
The issue with this is that any subsequent grunt tasks do not run. In our case, our grunt command sequence looked like:
['mockserver_start', 'cucumber', 'mockserver_stop']
In this case, if a test case failed, mockserver_stop was never invoked.
The expected behavior is that the task should succeed and failures should be dealt with by inspecting the test results in a subsequent step / process.
|
Looks good. I apologise, I don't get notifications from this repo for whatever crazy reason. |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Applied suggested fixes from ESLINT
-- Comment inline about potential breaking change in failed test handling