Support for Multi formatter #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mavdi Let me know what you think about this? Its keeping backward-compatibility by adding |
|
Hi @mavdi, can you take a look this PR? Thanks!! |
| e.g. `formats: ['html', 'pretty']` | ||
|
|
||
| Note: `html` formatter will provide Json as well as `html` report. Multiple formatter is supported for cucumber v@0.8.0 or higher | ||
|
|
There was a problem hiding this comment.
Should we add a peerDependency in package.json to make sure that cucumber@^0.8.0? This way we make sure that users do have the correct dependencies prior to using this feature.
There was a problem hiding this comment.
@nikulkarni thanks for reviewing. Multi-formats are not supported for version 0.7.0 and lesser, but still this plugin will still be used. If we add peerDependency for cucumber@^0.8.0 then plugin would throw the warning/error. What do you think?
|
Otherwise looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.formats
Supports multiple formatter.
Type:
ArrayAvailable:
['pretty', 'progress', 'summary', 'html']e.g.
formats: ['html', 'pretty']Note:
htmlformatter will provide Json as well ashtmlreport. Multiple formatter is supported for cucumber v@0.8.0 or higher