Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RR backends #57

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Refactor RR backends #57

merged 2 commits into from
Jun 21, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jun 21, 2024

To allow overriding them explicitly, also introduce Mojo configurations (and project properties support) for them. Also, from now on libYear will not "swallow" IAEx if no RR could be selected, but will error, forcing user to set one.

And allow Mojo configuration to override them, if needed.
This now makes possible to configure (in case of Mojos) either
by using `-Dtoolbox.search.backend.type=foo` on CLI, or
in project properties `toolbox.search.backend.type` or
as any ordinary Mojo by config using `repositoryVendor` element.
@cstamas
Copy link
Member Author

cstamas commented Jun 21, 2024

Tested with:

  • mojo config repositoryVendor - OK
  • project property toolbox.search.backend.type - OK
  • CLI -Dtoolbox.search.backend.type=foo - OK
  • project property is overridden by CLI property toolbox.search.backend.type - OK

@cstamas cstamas merged commit f2458ed into main Jun 21, 2024
25 checks passed
@cstamas cstamas deleted the refactor-rr-backends branch June 21, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant