This repository has been archived by the owner on Apr 14, 2024. It is now read-only.
Zsh + Remove core count + Brew install function #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking for the install locally should in theory be faster than making a net request. Should be tested, seems a little bit slow for me. Maybe a different check might be better.
Zsh is the default shell on macOS, so use that instead of Bash. While Zsh is very similar to Bash, there are some incompatibilities. However I tested the script and it works fine.
According to [this article](https://spectra.mathpix.com/article/2024.01.00364/a-complete-guide-to-the-ninja-build-system) Ninja automatically uses the maximum amount of cores available. There is no need to check and set with -j${CORES}
|
The |
it's slightly faster than just `brew list`
Simplify `"${deps[@]}"` to just `$deps[@]`
So much faster....
Tell the user that we are checking the homebrew dependencies
|
Ok, I'll stop fiddling with this.... |
|
Thanks for PR! ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few small changes:
-j${CORES}arg from buildingReasons for the changes:
brew installcommand. Output is cleanerbut it seems a bit slow to me. Maybe there is a better way to check, or maybe the existing command is faster.Needs testing. Edit: Updated to check for presence in$(brew --prefix)/opt/, it is fast now.