This repository has been archived by the owner on Apr 14, 2024. It is now read-only.
Build using Qt6 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since homebrew versions of Qt5 and Qt6 don't co-exist happily, this commit updates to Qt6. Works fine, but I've had to set `-DYUZU_USE_EXTERNAL_VULKAN_HEADERS=OFF` to avoid an error about an alias already existing. This is not ideal, because a user can update their local vulkan-headers independently. A better fix to the alias issue would be preferred.
|
Thanks for the PR! 🖤 Sorry lately haven't got much time to maintain this repo at some point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since homebrew versions of Qt5 and Qt6 don't co-exist happily, this commit updates to Qt6.
Works fine, but I've had to set
-DYUZU_USE_EXTERNAL_VULKAN_HEADERS=OFFto avoid an error about an alias already existing. This is not ideal, because a user can update their local vulkan-headers independently and potentially break things.A fix for the alias issue would be preferred.
Also, I changed the build type to release, instead of release with debug info. This should in theory improve performance slightly.