Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all content from mavlink.org with warnings #34

Closed
25 tasks done
hamishwillee opened this issue Feb 9, 2018 · 10 comments
Closed
25 tasks done

Migrate all content from mavlink.org with warnings #34

hamishwillee opened this issue Feb 9, 2018 · 10 comments
Assignees

Comments

@hamishwillee
Copy link
Collaborator

hamishwillee commented Feb 9, 2018

The content on mavlink.org is of unknown quality. I have been unable to get support with reviewing it and determining quality.

Plan is to import all the content and add a disclaimer that it is unverified/may be out of date/needs checking. I may also group it all in a folder that reflects that status.

Also will delete anything I am able to identify as not useful or already ported.

General:

  • Update top header bar so goes to correct new sites.

List of all remaining docs (checked means "dealt with")

@hamishwillee hamishwillee self-assigned this Feb 9, 2018
@mrpollo
Copy link
Member

mrpollo commented Feb 9, 2018

To be clear, by "unknown quality" you mean we aren't sure if the messages are being used and if the intention for such messages is unclear or undefined.

Another option would be to mark the parts we have support for in PX4 or APM (or any other consumer) it's a good idea because instead of focusing on what we don't know we are promoting the good parts, e.g.:

Message Supported in
MAV_MISSION_TYPE_MISSION PX4, APM
RANDOM_MAV_MSG_ONLYFOUND_IN_PX4 PX4
RANDOM_MAV_MESSAGE (unknown support, we don't list PX4 as supported)

@hamishwillee
Copy link
Collaborator Author

No, to be clear the documentation I am referring too has little or nothing to do with messages. It is documentation about the protocol that was written a long time ago and that was not migrated. It may no longer be accurate or useful - no one knows.

@hamishwillee
Copy link
Collaborator Author

Another option would be to mark the parts we have support for in PX4 or APM (or any other consumer) it's a good idea because instead of focusing on what we don't know we are promoting the good parts, e.g.:

Yes, it would be good to mark supported messages by autopilot, but IMO that would best be added in the message xml somehow. @julianoes Is there any way to add autopilot support to the mavlink message format like a "comment" so that it will be ignored by toolchain(s) but can be picked up by docs toolchains?

@hamishwillee
Copy link
Collaborator Author

Today did the following updates:

@julianoes
Copy link
Contributor

@hamishwillee the problem with documenting if something is supported by the Firmware is that some messages and commands are partially supported. E.g. only some params of a command are supported such as a coordinate frame.

@hamishwillee
Copy link
Collaborator Author

@hamishwillee the problem with documenting if something is supported by the Firmware is that some messages and commands are partially supported. E.g. only some params of a command are supported such as a coordinate frame.

@julianoes True. For or ardupilot I did this manually and re-documented every single (cursed) MAV_CMD_ showing what was supported and not supported. Do not want to go there again!

We could do this by allowing an attribute to be added to any xml tag that takes some accepted values. So supported="px4-full, apm-partial"
Then for this say:

      <entry value="176" name="MAV_CMD_DO_SET_MODE" supported="px4-full, apm-partial">
        <description>Set system mode.</description>
        <param index="1">Mode, as defined by ENUM MAV_MODE</param>
        <param index="2" supported="apm-not">Custom mode - this is system specific, please refer to the individual autopilot specifications for details.</param>
...

Alternatively maybe a support tag and just have a description.

      <entry value="176" name="MAV_CMD_DO_SET_MODE">
        <description>Set system mode.</description>
        <supported stack="px4">Full Support.</supported>
        <supported stack="apm">Partial support - does not support X, Y, Z params</supported>
        <param index="1">Mode, as defined by ENUM MAV_MODE</param>
        <param index="2">Custom mode - this is system specific, please refer to the individual autopilot specifications for details.</param>
...

@mrpollo Any other suggestions? This is not easy!

@julianoes
Copy link
Contributor

I think the support flags should live in the Firmware repo though, otherwise they'll be out of date, always.

@hamishwillee
Copy link
Collaborator Author

True. This discussion has hijacked this issue. I've spawned it off to #39 so it doesn't get lost, but I think possibly a too big problem/non priority for tackling right now

@julianoes
Copy link
Contributor

My answer to share what is compatible is DroneCore 😄

@hamishwillee
Copy link
Collaborator Author

Everything migrated of interest. Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants