Move enums in description to real enums

[patrickelectric]

E.g: MAV_CMD_DO_CHANGE_SPEED, has on the first field:

<param index="1" label="Speed Type" minValue="0" maxValue="3" increment="1">Speed type (0=Airspeed, 1=Ground Speed, 2=Climb Speed, 3=Descent Speed)</param>

The speed type should be defined in an enum, and not being used in the description.

Doing so will empower the tools that use the specification to also provide possible valid values without parsing the description (that's just a text without xml validation).

[hamishwillee]

We often don't want to clutter the namespace if there are only a few values to use and they are unlikely to be extended. On the other hand, enums make it clear than you mean "this value" and prevents flight stacks from doing things like assuming values will not change and condition of greater-than.

I'd be happy with this. Do you want to PR it?

[hamishwillee]

@patrickelectric ^^^^ ?

[patrickelectric]

Hi @hamishwillee, sorry, I'm in vacation, should be back on this before the end of the month.

[hamishwillee]

Cool, should be fixed by #2039

[patrickelectric]

Hi @hamishwillee, sorry for not answering it before!

As said, make them as enum help us to have clear behavior and intention. Hiding enums under ranges makes it harder to define and make it clear for the user and tools how the values are used.

[hamishwillee]

No worries. All good. Merged!