mavros/src/plugins/command.cpp: log if command's wait ack timeout #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vooon
reviewed
Apr 19, 2019
szobov
force-pushed
the
log-command-timeout
branch
from
4e41788
to
d337c5e
Compare
szobov
force-pushed
the
log-command-timeout
branch
from
d337c5e
to
92c90ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's confusing now, when you receive an answer: 4 (
MAV_RESULT_FAILED) on command long, because after you dig into command processing side, in my case it's px4 firmware, you'll see that there is no possible answerMAV_RESULT_FAILEDon the command.This changes make it more explicit.
Thanks!