Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some build warnings in the mavros and mavros_extras packages when I build locally with Clang, which I've attempted to fix.
I think some of these changes are uncontroversial, such as
There was also a warning where
MissionBase::initialize(ros::NodeHandle *_wp_nh)
upsets the compiler because it "hides the overloaded virtual functionPluginBase::initialize(UAS &uas)
because MissionBase inherits from PluginBase. I've avoided this by renamingMissionBase::initialize
but you may want to solve it differently, or give it a different name.After this, all that remains when I build are unused variable warnings, mostly about
COV_SIZE
which is only used in debug builds. I suppose this could be fixed with the casting to void trick(void)COV_SIZE
or with[maybe_unused](https://en.cppreference.com/w/cpp/language/attributes/maybe_unused)
(but that would require C++17). Locally I've silenced this with a few#pragma GCC diagnostic ignored "-Wunused-variable"
.