libmavconn: fix deadlock when call close() #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling the close() function (by a different thread), a lock (mutex) is taken at the start of this function which closes the socket and waits the end of io_service thread. Closing the socket causes the 'Operation aborted' error in do_recv() function called by io_service thread which in turn calls the close() function: sthis->close(). This causes a 'deadlock'. fix: Reduce the scope of the lock in the close() function so that it is released before waiting for the thread to end.
SylvainPastor
pushed a commit
to SylvainPastor/mavros
that referenced
this pull request
Mar 3, 2022
Same problems as for the TCP: - mavlink#1682: fix std::system_error when tcp interface loses connection - mavlink#1679: fix deadlock when call close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MavconnTCPClient: When calling the
close()function (by a different thread), a mutex is taken atthe start of this function which closes the socket and waits the end of io_service thread.
Closing the socket causes the
Operation abortederror indo_recv()function called byio_service thread which in turn calls the
close()function.This causes a 'deadlock'.
fix: Reduce the scope of the mutex in the
close()function so that it is released beforewaiting the end of io_service thread.