fix std::system_error when tcp interface loses connection #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the tcp connection is lost (remote TCP server stopped), an 'End of file' error is caught
by the io_thread in the do_recv() that calls the close() function.
In the close() function, we stop the io_service and wait for the end of the io_thread which
causes an std::system_error exception (cause: Resource deadlock avoided).
Error: mavconn: tcp0: receive: End of file at line 250 in libmavconn/src/tcp.cpp
terminate called after throwing an instance of 'std::system_error'
what(): Resource deadlock avoided
Aborted (core dumped)
fix:
- close() function: stop io_service if current thread id != io_thread id
- ~MAVConnTCPClient(): stop io_service and io_thread if thread is running
|
Personally, in the Especially in the case where the connection is created by the |
|
I have 2 style errors, I will correct them |
SylvainPastor
pushed a commit
to SylvainPastor/mavros
that referenced
this pull request
Mar 3, 2022
Same problems as for the TCP: - mavlink#1682: fix std::system_error when tcp interface loses connection - mavlink#1679: fix deadlock when call close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tcp connection is lost (remote TCP server stopped), an
End of fileerror is caughtby the
io_threadin thedo_recv()that calls theclose()function.In the
close()function, we stop the io_service and wait the end of the io_thread whichcauses an
std::system_error exception(cause: Resource deadlock avoided).fix:
- close() function: stop io_service if current thread id != io_thread id
- ~MAVConnTCPClient(): stop io_service and io_thread if thread is running