Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount control plugin: add configurable diagnostics #1702

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Mount control plugin: add configurable diagnostics #1702

merged 2 commits into from
Feb 16, 2022

Conversation

amilcarlucas
Copy link
Contributor

No description provided.

vooon
vooon reviewed Feb 16, 2022
View reviewed changes
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

mavros_extras/src/plugins/mount_control.cpp Show resolved Hide resolved
@vooon vooon added this to the Version 1.14 milestone Feb 16, 2022
@amilcarlucas
mount_control.cpp: use mount_nh for params to keep similarities with …
880d808 
…other plugins

set diag settings before add()
vooon
vooon approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vooon vooon merged commit 0b2d5ba into mavlink:master Feb 16, 2022
@amilcarlucas amilcarlucas deleted the mount_diagnostics branch February 16, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vooon vooon vooon approved these changes

Assignees
No one assigned
Labels
enhancement extras
Projects
None yet
Milestone
Version 1.14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amilcarlucas @vooon