sys_status.cpp: ignore sys_status mavlink messages from gimbals #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vooon
requested changes
Feb 16, 2022
mavros/src/plugins/sys_status.cpp
Outdated
| @@ -761,6 +761,9 @@ class SystemStatusPlugin : public plugin::PluginBase | |||
|
|
|||
| void handle_sys_status(const mavlink::mavlink_message_t *msg, mavlink::common::msg::SYS_STATUS &stat) | |||
| { | |||
| if ((mavlink::minimal::MAV_COMPONENT)msg->compid == mavlink::minimal::MAV_COMPONENT::COMP_ID_GIMBAL) | |||
There was a problem hiding this comment.
Plase use static_cast & using.
using MC = mavlink::minimal::MAV_COMPONENT;
if (static_cast<MC>(msg->compid) == MC::COMP_ID_GIMBAL)
return;
amilcarlucas
force-pushed
the
ignore-gimbal-sys-status
branch
from
25bac50
to
ee92e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this gimbal reported errors are classified as UAV errors, and that is not good.