sys_status.cpp: fix enabling of mem_diag and hwst_diag #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes the diagnostics run, tested in HW |
vooon
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
That potentially can have threading access trouble because last_rcd isn't atomic (and can't be), so we have to use either mutex or std::atomic<uint64_t> to store stamp nanoseconds.
struct A {
std::atomic<uint64_t> stamp;
};
a.stamp = ros::Time::now().toNSec();
auto stamp = ros::Time::fromNSec(a.stamp.load());
But overall looks ok.
…publish on the diagnostics Use atomic variable to prevent potential threading problems
amilcarlucas
force-pushed
the
fix-disabled-diagnostics
branch
from
7a4348b
to
6f1604e
Compare
|
fixed, good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.